[SPARK-42831][SQL] Show result expressions in AggregateExec#40461
Closed
wankunde wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-42831][SQL] Show result expressions in AggregateExec#40461wankunde wants to merge 4 commits intoapache:masterfrom
wankunde wants to merge 4 commits intoapache:masterfrom
Conversation
a369610 to
2aa67ff
Compare
2aa67ff to
1ece614
Compare
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If the result expressions in AggregateExec are not empty, we should display them. Or we will get confused because some important expressions do not show up in the DAG.
Why are the changes needed?
For example, the plan for query
SELECT sum(p) from values(cast(23.4 as decimal(7,2))) t(p)was incorrect because the result expressionMakeDecimal(sum(UnscaledValue(p#0))#1L,17,2) AS sum(p)#2is not displayedBefore
After
Does this PR introduce any user-facing change?
No
How was this patch tested?
Local test