[SPARK-42914][PYTHON][3.4] Reuse transformUnregisteredFunction for DistributedSequenceID.#40554
Closed
itholic wants to merge 2 commits into
Closed
[SPARK-42914][PYTHON][3.4] Reuse transformUnregisteredFunction for DistributedSequenceID.#40554itholic wants to merge 2 commits into
transformUnregisteredFunction for DistributedSequenceID.#40554itholic wants to merge 2 commits into
Conversation
…stributedSequenceID.
Contributor
Author
|
cc @HyukjinKwon |
HyukjinKwon
approved these changes
Mar 27, 2023
Member
|
Oh im sorry. Actually we don't need this for 3.4 since pandas API in spark will be in 3.5 only |
Contributor
Author
|
np! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Backport for #40540
This PR proposes refactoring
DistributedSequenceIDby leveragingtransformUnregisteredFunctionand remote it from proto message.Why are the changes needed?
To follow the existing structure and make proto messages simpler.
Does this PR introduce any user-facing change?
No, it's used for internal purpose.
How was this patch tested?
Updated UTs.