[SPARK-42950][CORE] Add exit code in SparkListenerApplicationEnd#40591
Closed
paul-laffon-dd wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-42950][CORE] Add exit code in SparkListenerApplicationEnd#40591paul-laffon-dd wants to merge 1 commit intoapache:masterfrom
paul-laffon-dd wants to merge 1 commit intoapache:masterfrom
Conversation
HyukjinKwon
reviewed
Mar 30, 2023
|
|
||
| @DeveloperApi | ||
| case class SparkListenerApplicationEnd(time: Long) extends SparkListenerEvent | ||
| case class SparkListenerApplicationEnd(time: Long, exitCode: Option[Int] = None) |
Member
There was a problem hiding this comment.
we'll have to define another constructor instead of using default value which breaks binary compat (and +source compat if you use Java)
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The exit code is already available in the
stop(exitCode: Int)function of the SparkContext, it only can be propagated to the eventSparkListenerApplicationEndthat is emitted in thepostApplicationEndUsing an
Option[Int]to reflect that the exit code can be missing if reading an event log of a previous version of sparkWhy are the changes needed?
Being able to know if a spark application succeeded or failed when using the spark listener API
Does this PR introduce any user-facing change?
Yes, adding a new field
exitCodetoSparkListenerApplicationEnd, which is marked as@DeveloperApiHow was this patch tested?
Updated the unit tests to make sure the value is correctly propagated
Launched a spark application from this branch, and looking at the last emitted event