Improve IDE build experience against jdk11#40667
Closed
ksumit wants to merge 1 commit intoapache:masterfrom
Closed
Improve IDE build experience against jdk11#40667ksumit wants to merge 1 commit intoapache:masterfrom
ksumit wants to merge 1 commit intoapache:masterfrom
Conversation
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Building the project against jdk11 on IDE shows errors because
Platform.javadepends onsun.miscwhich is injdk.unsupportedmodule in jdk11. The problem goes away when we passjava.versionas11to maven as system D parameters.This PR set
java.versionto11by detecting jdk version automatically and improves build experience.Why are the changes needed?
It makes build experience on IDE against jdk11 smoother.
Does this PR introduce any user-facing change?
Users won't have to specify java.version in maven parameters any more since the profile gets activated automagically based on the jdk version.
How was this patch tested?
This patch was tested by building locally.