[SPARK-43064][SQL] Spark SQL CLI SQL tab should only show once statement once#40701
Closed
AngersZhuuuu wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-43064][SQL] Spark SQL CLI SQL tab should only show once statement once#40701AngersZhuuuu wants to merge 4 commits intoapache:masterfrom
AngersZhuuuu wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
ping @cloud-fan |
cloud-fan
reviewed
Apr 7, 2023
...hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLDriver.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Apr 7, 2023
...hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLDriver.scala
Outdated
Show resolved
Hide resolved
Contributor
|
#40437 might be related. We want to remove |
Contributor
Author
|
ping @cloud-fan |
jaceklaskowski
approved these changes
Apr 11, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
cc @sunchao because he is also an expert in this domain.
sunchao
approved these changes
Apr 13, 2023
Member
sunchao
left a comment
sunchao
left a comment
There was a problem hiding this comment.
Looks OK to me. It'd be better if we can update the PR description to explain more why this PR is needed and what changes are proposed here.
| val execution = context.sessionState.executePlan(context.sql(command).logicalPlan) | ||
| hiveResponse = SQLExecution.withNewExecutionId(execution, Some("cli")) { | ||
| hiveResultString(execution.executedPlan) | ||
| // Command type sql have been executed when call `context.sql(command).logicalPlan`, |
Member
There was a problem hiding this comment.
this comment is not very easy to understand: what is `Command type sql"? maybe:
The SQL command has been executed above via `executePlan`, therefore we don't need to wrap it again
with a new execution ID when getting Hive result
?
Member
|
Merged to master, thanks! |
Member
|
Thank you all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Before
After
Why are the changes needed?
Don't need show twice, too weird
Does this PR introduce any user-facing change?
No
How was this patch tested?
MT