Skip to content

Comments

[WIP][SPARK-43112]. Spark may use a column other than the actual specified partitioning column for partitioning, for Hive format tables#40765

Closed
ahshahid wants to merge 3 commits intoapache:masterfrom
ahshahid:SPARK-43112
Closed

[WIP][SPARK-43112]. Spark may use a column other than the actual specified partitioning column for partitioning, for Hive format tables#40765
ahshahid wants to merge 3 commits intoapache:masterfrom
ahshahid:SPARK-43112

Conversation

@ahshahid
Copy link
Contributor

What changes were proposed in this pull request?

Right now only bug test. still figuring out a clean way to fix.

Why are the changes needed?

the checked in bug test describes the issue. It appears to me that spark-hive column mapping especially for insert is severely broken. I am not sure why the issue has remained hidden so far.

Does this PR introduce any user-facing change?

No

How was this patch tested?

not tested

@github-actions github-actions bot added the SQL label Apr 12, 2023
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @sunchao because this is Hive-related stuff

@ahshahid ahshahid closed this Apr 20, 2023
@ahshahid
Copy link
Contributor Author

I will close this PR. Though there is problematic behaviour if the column name is present in column list as well as in partition clause, and in case of hive tables, that situation should be detected . But it is not that severe a bug, as for hive table format the partition col should not be present in both the places ( i was not aware of that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants