[WIP][PYTHON][TESTS] Reduce the required resources in PyTorch related tests#40769
Closed
zhengruifeng wants to merge 5 commits intoapache:masterfrom
Closed
[WIP][PYTHON][TESTS] Reduce the required resources in PyTorch related tests#40769zhengruifeng wants to merge 5 commits intoapache:masterfrom
zhengruifeng wants to merge 5 commits intoapache:masterfrom
Conversation
HyukjinKwon
approved these changes
Apr 13, 2023
Contributor
Author
|
@HyukjinKwon do we have a timeout parameter for python unittest? The issue happens occasionally, I want to fail the test if it is too long (maybe 10min) so that reviews at least will be aware of that the failure is unrelated |
Member
|
We don't have. We have |
zhengruifeng
force-pushed
the
torch_test_reduce_resource
branch
2 times, most recently
from
6dcb7bb to
afac7f1
Compare
zhengruifeng
force-pushed
the
torch_test_reduce_resource
branch
from
afac7f1 to
fd03938
Compare
zhengruifeng
force-pushed
the
torch_test_reduce_resource
branch
from
fd03938 to
03b403c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PyTorch distributor run on barrier mode, when the resources is not enough for some reason,
test_parity_torch_distributorcan wait for hours.Why are the changes needed?
for tests
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI