[SPARK-43125][CONNECT] Fix Connect Server Can't Handle Exception With Null Message

[Hisoka-X]

What changes were proposed in this pull request?

Fix the bug when Connect Server throw Exception without message.

Why are the changes needed?

Fix bug

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unnecessary

[Hisoka-X]

@martin-g @HyukjinKwon PTAL. Thanks

[LuciferYang]

Could you add a test case for this scenario?

[LuciferYang]

hmm.. there is no [SERVER] tag, we should remove if from pr title

[HyukjinKwon]

Merged to master and branch-3.4.

[WweiL]

@Hisoka-X @HyukjinKwon Any reason we drop the abbreviate?

[Hisoka-X]

@Hisoka-X @HyukjinKwon Any reason we drop the abbreviate?

Sorry, I don't get it. What do you mean about drop the abbreviate? This PR just do null check.

[WweiL]

@Hisoka-X @HyukjinKwon Any reason we drop the abbreviate?

Sorry, I don't get it. What do you mean about drop the abbreviate? This PR just do null check.

Ah sorry! I didn't see you did the abbreviate in the top, please ignore this!

[WweiL]

@Hisoka-X @HyukjinKwon Any reason we drop the abbreviate?

Sorry, I don't get it. What do you mean about drop the abbreviate? This PR just do null check.

Ah sorry! I didn't see you did the abbreviate in the top, please ignore this!

[WweiL]

@Hisoka-X I think we also change this line?
https://github.com/apache/spark/pull/40780/files#diff-d21a96890e660df398527183a191b0d0c73521aada856e2491c33243f269fdceR128

I could add it to my ongoing PR #40785

[Hisoka-X]

@Hisoka-X I think we also change this line? https://github.com/apache/spark/pull/40780/files#diff-d21a96890e660df398527183a191b0d0c73521aada856e2491c33243f269fdceR128

I could add it to my ongoing PR #40785

OK for me, but I just want to remind, add null check just want to avoid throw NPE in setMessage, not want to change null to ""

[WweiL]

@Hisoka-X I think we also change this line? https://github.com/apache/spark/pull/40780/files#diff-d21a96890e660df398527183a191b0d0c73521aada856e2491c33243f269fdceR128
I could add it to my ongoing PR #40785

OK for me, but I just want to remind, add null check just want to avoid throw NPE in setMessage, not want to change null to ""

I see. With additional look I think here it's better to keep what it is. as Status's description is nullable:

private Status(Code code, @Nullable String description, @Nullable Throwable cause) {
    this.code = checkNotNull(code, "code");
    this.description = description;
    this.cause = cause;
  }

public Status withDescription(String description) {
    if (Objects.equal(this.description, description)) {
      return this;
    }
    return new Status(this.code, description, this.cause);
  }