[SPARK-43130][SQL] Move InternalType to PhysicalDataType#40784
Closed
amaliujia wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-43130][SQL] Move InternalType to PhysicalDataType#40784amaliujia wants to merge 4 commits intoapache:masterfrom
amaliujia wants to merge 4 commits intoapache:masterfrom
Conversation
… to use PhysicalDataType whenever makes sense.
Contributor
Author
Contributor
Author
|
In fact the compilation is failing on tests. let me fix it first. |
Contributor
Author
|
Test issues should have been fixed. |
cloud-fan
approved these changes
Apr 14, 2023
Contributor
|
thanks, merging to master! |
kerwin-zk
pushed a commit
to apache/celeborn
that referenced
this pull request
Sep 5, 2024
### What changes were proposed in this pull request? Introduce `spark-3.5-columnar-shuffle` module to support columnar shuffle for Spark 3.5. ### Why are the changes needed? #1850 does not support columnar shuffle for Spark 3.5, in which version building `spark-3-columnar-shuffle` module has compilation error. The compilation error is caused by apache/spark#40784, which incompatible changes move `InternalType` from `AtomicType` to `PhysicalDataType`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. Closes #2710 from SteNicholas/CELEBORN-912. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: xiyu.zk <xiyu.zk@alibaba-inc.com>
s0nskar
pushed a commit
to s0nskar/celeborn
that referenced
this pull request
Sep 16, 2024
### What changes were proposed in this pull request? Introduce `spark-3.5-columnar-shuffle` module to support columnar shuffle for Spark 3.5. ### Why are the changes needed? apache#1850 does not support columnar shuffle for Spark 3.5, in which version building `spark-3-columnar-shuffle` module has compilation error. The compilation error is caused by apache/spark#40784, which incompatible changes move `InternalType` from `AtomicType` to `PhysicalDataType`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. Closes apache#2710 from SteNicholas/CELEBORN-912. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: xiyu.zk <xiyu.zk@alibaba-inc.com>
wankunde
pushed a commit
to wankunde/celeborn
that referenced
this pull request
Oct 11, 2024
### What changes were proposed in this pull request? Introduce `spark-3.5-columnar-shuffle` module to support columnar shuffle for Spark 3.5. ### Why are the changes needed? apache#1850 does not support columnar shuffle for Spark 3.5, in which version building `spark-3-columnar-shuffle` module has compilation error. The compilation error is caused by apache/spark#40784, which incompatible changes move `InternalType` from `AtomicType` to `PhysicalDataType`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. Closes apache#2710 from SteNicholas/CELEBORN-912. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: xiyu.zk <xiyu.zk@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR drops
InternalTypefrom the logical data type and refactors to use the PhysicalDataType and InternalType.Why are the changes needed?
To simplify DataType interface.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
UT