[SPARK-43169][INFRA] Bump previousSparkVersion to 3.4.0#40830
Closed
LuciferYang wants to merge 3 commits into
Closed
[SPARK-43169][INFRA] Bump previousSparkVersion to 3.4.0#40830LuciferYang wants to merge 3 commits into
previousSparkVersion to 3.4.0#40830LuciferYang wants to merge 3 commits into
Conversation
LuciferYang
commented
Apr 18, 2023
| org.apache.spark.tools.GenerateMIMAIgnore | ||
|
|
||
| echo -e "q\n" | build/sbt -mem 4096 -DcopyDependencies=false "$@" mimaReportBinaryIssues | grep -v -e "info.*Resolving" | ||
| echo -e "q\n" | build/sbt -mem 4196 -DcopyDependencies=false "$@" mimaReportBinaryIssues | grep -v -e "info.*Resolving" |
Contributor
Author
There was a problem hiding this comment.
Add more 100m mem to avoid:
java.lang.OutOfMemoryError: GC overhead limit exceeded
at java.lang.StringBuilder.toString(StringBuilder.java:412)
at com.typesafe.tools.mima.core.MemberInfo.fullName(MemberInfo.scala:16)
at com.typesafe.tools.mima.core.Problem.matchName(Problems.scala:19)
at com.typesafe.tools.mima.core.ProblemFilters$ExcludeByName.apply(ProblemFilters.scala:12)
at com.typesafe.tools.mima.core.ProblemFilters$ExcludeByName.apply(ProblemFilters.scala:8)
at com.typesafe.tools.mima.core.ProblemReporting$.$anonfun$isReported$2(ProblemReporting.scala:27)
at com.typesafe.tools.mima.core.ProblemReporting$.$anonfun$isReported$2$adapted(ProblemReporting.scala:27)
at com.typesafe.tools.mima.core.ProblemReporting$$$Lambda$5945/1166075121.apply(Unknown Source)
at scala.collection.Iterator.forall(Iterator.scala:955)
at scala.collection.Iterator.forall$(Iterator.scala:953)
at scala.collection.Iterator$ConcatIterator.forall(Iterator.scala:179)
at com.typesafe.tools.mima.core.ProblemReporting$.isReported(ProblemReporting.scala:27)
at com.typesafe.tools.mima.plugin.SbtMima$.isReported$1(SbtMima.scala:61)
at com.typesafe.tools.mima.plugin.SbtMima$.$anonfun$reportModuleErrors$3(SbtMima.scala:70)
at com.typesafe.tools.mima.plugin.SbtMima$.$anonfun$reportModuleErrors$3$adapted(SbtMima.scala:70)
at com.typesafe.tools.mima.plugin.SbtMima$$$Lambda$5939/1088203167.apply(Unknown Source)
at scala.collection.TraversableLike.noneIn$1(TraversableLike.scala:319)
at scala.collection.TraversableLike.filterImpl(TraversableLike.scala:385)
at scala.collection.TraversableLike.filterImpl$(TraversableLike.scala:297)
at scala.collection.AbstractTraversable.filterImpl(Traversable.scala:108)
at scala.collection.TraversableLike.filter(TraversableLike.scala:395)
at scala.collection.TraversableLike.filter$(TraversableLike.scala:395)
at scala.collection.AbstractTraversable.filter(Traversable.scala:108)
at com.typesafe.tools.mima.plugin.SbtMima$.reportModuleErrors(SbtMima.scala:70)
at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$projectSettings$2(MimaPlugin.scala:36)
at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$projectSettings$2$adapted(MimaPlugin.scala:26)
at com.typesafe.tools.mima.plugin.MimaPlugin$$$Lambda$5178/1097580344.apply(Unknown Source)
at scala.collection.Iterator.foreach(Iterator.scala:943)
at scala.collection.Iterator.foreach$(Iterator.scala:943)
at scala.collection.AbstractIterator.foreach(Iterator.scala:1431)
at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$projectSettings$1(MimaPlugin.scala:26)
at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$projectSettings$1$adapted(MimaPlugin.scala:25)
[error] [launcher] error during sbt launcher: java.lang.OutOfMemoryError: GC overhead limit exceeded
Member
There was a problem hiding this comment.
@LuciferYang just to double check, did this happen very frequently? I wonder this memory setting makes our CI flaky
Contributor
Author
There was a problem hiding this comment.
Does the GA instance still allow us to add more memory? If possible, we should continue to increase.
I give #40862 to test on GA
If we cannot add more memory, we need to roll back this patch and refactor the mima check mechanism
Contributor
Author
There was a problem hiding this comment.
In the previous local testing, GC overhead limit exceeded not occur again for mem 4196, but I see that GA still has this issue.
Contributor
Author
|
cc @dongjoon-hyun @HyukjinKwon FYI |
HyukjinKwon
approved these changes
Apr 19, 2023
Member
|
Merged to master. |
Contributor
Author
|
Thanks @HyukjinKwon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The main change of this pr as follows:
previousSparkVersionto 3.4.0shaded and generated protobuf codeexclude filters todefaultExcludesjava.lang.OutOfMemoryError: GC overhead limit exceededWhy are the changes needed?
To ensure that MiMa checks cover new APIs added in Spark 3.4.0.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Scala 2.12
Scala 2.13