[SPARK-43208][SQL][HIVE] IsolatedClassLoader should close barrier class InputStream after reading#40867
Closed
pan3793 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-43208][SQL][HIVE] IsolatedClassLoader should close barrier class InputStream after reading#40867pan3793 wants to merge 1 commit intoapache:masterfrom
pan3793 wants to merge 1 commit intoapache:masterfrom
Conversation
…putStream after reading
Contributor
|
Good catch |
pan3793
commented
Apr 20, 2023
| if (loaded == null) doLoadClass(name, resolve) else loaded | ||
| } | ||
| def doLoadClass(name: String, resolve: Boolean): Class[_] = { | ||
| val classFileName = name.replaceAll("\\.", "/") + ".class" |
Member
Author
There was a problem hiding this comment.
it's exactly same as classToPath(name)
Member
Author
HyukjinKwon
approved these changes
Apr 20, 2023
LuciferYang
approved these changes
Apr 20, 2023
sunchao
approved these changes
Apr 20, 2023
sunchao
changed the title
Member
|
@pan3793 good catch, have you seen any issue caused by this? |
Member
|
Merged to master, thanks! |
Member
Author
Not exactly. Since the current Hive 2.3.9 can talk w/ HMS 2.1+ smoothly (plus HIVE-25500, the HMS versions expand to 1.2+), it's rare to use a custom Hive client version in our production cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As title, close the barrier class
InputStreamafter reading inIsolatedClassLoaderWhy are the changes needed?
IOUtils.toByteArray(inputStream)is not responsible to close theinputStream, the caller should do closing instead.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.