[SPARK-43230][CONNECT] Simplify DataFrameNaFunctions.fillna#40898
[SPARK-43230][CONNECT] Simplify DataFrameNaFunctions.fillna#40898zhengruifeng wants to merge 2 commits intoapache:masterfrom
DataFrameNaFunctions.fillna#40898Conversation
a3b7db4 to
16a7e44
Compare
seems Mima also check |
|
|
||
| // DataFrameNaFunctions | ||
| ProblemFilters.exclude[Problem]("org.apache.spark.sql.DataFrameNaFunctions.this"), | ||
| ProblemFilters.exclude[Problem]("org.apache.spark.sql.DataFrameNaFunctions.fillValue"), |
There was a problem hiding this comment.
@LuciferYang it seems the MiMa tests also check private[sql], is this as expected?
There was a problem hiding this comment.
This behavior is expected now, but I think some refactoring work is needed to automatically filter similar checks, just like what dev/mima check does.
There was a problem hiding this comment.
got it, thanks
There was a problem hiding this comment.
filed https://issues.apache.org/jira/browse/SPARK-43246 to tracking this
There was a problem hiding this comment.
Also cc @zhenlineo, @hvanhovell do you have any good suggestions about this
There was a problem hiding this comment.
#40925 try to solve this issue, but it will make CheckConnectJvmClientCompatibility spend more time and maybe more complex
|
Thanks for the reviews, merged to master |
What changes were proposed in this pull request?
add a helper function in
DataFrameNaFunctionsWhy are the changes needed?
to Simplify
DataFrameNaFunctions.fillnaDoes this PR introduce any user-facing change?
no, dev-only
How was this patch tested?
existing UTs