[SPARK-43279][CORE] Cleanup unused members from SparkHadoopUtil
#40942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
May 4, 2023
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Looks good, mark it ready to merge when ready
Member
|
Merged to master |
Contributor
Author
|
Thanks @srowen |
LuciferYang
added a commit
to LuciferYang/spark
that referenced
this pull request
May 10, 2023
### What changes were proposed in this pull request? This pr clean up the following unused members from `SparkHadoopUtil`: - `listLeafDirStatuses`: introduced by SPARK-3928 and no longer used after SPARK-7673 - `listFilesSorted`: introduced by SPARK-5342 and no longer used after SPARK-23361 - `getSuffixForCredentialsPath`: same as `listFilesSorted` - `SPARK_YARN_CREDS_TEMP_EXTENSION`: same as `listFilesSorted` - `SPARK_YARN_CREDS_COUNTER_DELIM`: same as `listFilesSorted` ### Why are the changes needed? Code cleanup ### Does this PR introduce _any_ user-facing change? No, all cleaned up are internal APIs ### How was this patch tested? Pass GitHub Action Closes apache#40942 from LuciferYang/SPARK-43279. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Sean Owen <srowen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr clean up the following unused members from
SparkHadoopUtil:listLeafDirStatuses: introduced by SPARK-3928 and no longer used after SPARK-7673listFilesSorted: introduced by SPARK-5342 and no longer used after SPARK-23361getSuffixForCredentialsPath: same aslistFilesSortedSPARK_YARN_CREDS_TEMP_EXTENSION: same aslistFilesSortedSPARK_YARN_CREDS_COUNTER_DELIM: same aslistFilesSortedWhy are the changes needed?
Code cleanup
Does this PR introduce any user-facing change?
No, all cleaned up are internal APIs
How was this patch tested?
Pass GitHub Action