Skip to content

[SPARK-43285] Fix ReplE2ESuite consistently failing with JDK 17 #40948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vicennial wants to merge 1 commit into from
Closed

[SPARK-43285] Fix ReplE2ESuite consistently failing with JDK 17 #40948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...tor/connect/client/jvm/src/test/scala/org/apache/spark/sql/application/ReplE2ESuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,14 @@ import java.io.{PipedInputStream, PipedOutputStream}
import java.util.concurrent.{Executors, Semaphore, TimeUnit}

import org.apache.commons.io.output.ByteArrayOutputStream
import org.scalatest.BeforeAndAfterEach

import org.apache.spark.sql.connect.client.util.RemoteSparkSession

class ReplE2ESuite extends RemoteSparkSession {
class ReplE2ESuite extends RemoteSparkSession with BeforeAndAfterEach {

private val executorService = Executors.newSingleThreadExecutor()
private val TIMEOUT_SECONDS = 10
private val TIMEOUT_SECONDS = 30

private var testSuiteOut: PipedOutputStream = _
private var ammoniteOut: ByteArrayOutputStream = _
Expand Down Expand Up @@ -68,6 +69,10 @@ class ReplE2ESuite extends RemoteSparkSession {
super.afterAll()
}

override def afterEach(): Unit = {
semaphore.drainPermits()
}

def runCommandsInShell(input: String): String = {
require(input.nonEmpty)
// Pad the input with a semaphore release so that we know when the execution of the provided
Expand Down