[SPARK-43320][SQL][HIVE] Directly call Hive 2.3.9 API#40995
Closed
pan3793 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-43320][SQL][HIVE] Directly call Hive 2.3.9 API#40995pan3793 wants to merge 1 commit intoapache:masterfrom
pan3793 wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
srowen
approved these changes
Apr 28, 2023
Member
|
Merged to master |
Member
|
Late LGTM. Was trying to +1 and merge this but @srowen beat me on it. |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
May 10, 2023
### What changes were proposed in this pull request? Call Hive 2.3.9 API directly instead of reflection, basically reverts SPARK-37446. ### Why are the changes needed? Switch to direct calling to achieve compile time check. Spark does not officially support building against Hive other than 2.3.9, for cases listed in SPARK-37446, it's the vendor's responsibility to port HIVE-21563 into their maintained Hive 2.3.8-[vender-custom-version]. See full discussion in apache#40893. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes apache#40995 from pan3793/SPARK-43320. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Sean Owen <srowen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Call Hive 2.3.9 API directly instead of reflection, basically reverts SPARK-37446.
Why are the changes needed?
Switch to direct calling to achieve compile time check.
Spark does not officially support building against Hive other than 2.3.9, for cases listed in SPARK-37446, it's the vendor's responsibility to port HIVE-21563 into their maintained Hive 2.3.8-[vender-custom-version].
See full discussion in #40893.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.