[SPARK-43352][K8S][TEST] Inline DepsTestsSuite#setPythonSparkConfProperties#41030
Closed
pan3793 wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-43352][K8S][TEST] Inline DepsTestsSuite#setPythonSparkConfProperties#41030pan3793 wants to merge 2 commits intoapache:masterfrom
DepsTestsSuite#setPythonSparkConfProperties#41030pan3793 wants to merge 2 commits intoapache:masterfrom
Conversation
…nf instead of sparkAppConf
Member
Author
|
cc @HyukjinKwon |
HyukjinKwon
reviewed
May 3, 2023
...ration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DepsTestsSuite.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
approved these changes
May 3, 2023
pan3793
changed the title
setPythonSparkConfProperties should use conf instead of sparkAppConfDepsTestsSuite#setPythonSparkConfProperties
dongjoon-hyun
approved these changes
May 3, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Nice catch!
Thank you, @pan3793 and @HyukjinKwon .
Merged to master for Apache Spark 3.5.0.
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
May 10, 2023
…perties` ### What changes were proposed in this pull request? Inline `DepsTestsSuite#setPythonSparkConfProperties`, which was introduced in SPARK-27936. ### Why are the changes needed? The `setPythonSparkConfProperties` is only invoked in one place, doesn't look helping the readability much. Besides, it should use `conf` instead of `sparkAppConf` ### Does this PR introduce _any_ user-facing change? No. Since the caller always passes the `sparkAppConf`, this bug affects nothing actually. ### How was this patch tested? Pass GA. Closes apache#41030 from pan3793/SPARK-43352. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Inline
DepsTestsSuite#setPythonSparkConfProperties, which was introduced in SPARK-27936.Why are the changes needed?
The
setPythonSparkConfPropertiesis only invoked in one place, doesn't look helping the readability much. Besides, it should useconfinstead ofsparkAppConfDoes this PR introduce any user-facing change?
No. Since the caller always passes the
sparkAppConf, this bug affects nothing actually.How was this patch tested?
Pass GA.