[SPARK-43342][K8S] Revert SPARK-39006 Show a directional error message for executor PVC dynamic allocation failure#41069
[SPARK-43342][K8S] Revert SPARK-39006 Show a directional error message for executor PVC dynamic allocation failure#41069dongjoon-hyun wants to merge 1 commit intoapache:masterfrom dongjoon-hyun:SPARK-43342
Conversation
…tor PVC dynamic allocation failure" This reverts commit b065c94.
|
cc @dcoliversun This will be merged with your authorship. |
|
After merging this clean-revert, you may want to make a new and proper test PR for https://github.com/apache/spark/pull/41057/files#r1186469992 if you want. |
|
@dongjoon-hyun Thanks for your PR. I'm +1 |
|
Thank you, @dcoliversun . |
|
Could you review this PR, @viirya ? |
|
May I ask why this is reverted? |
|
Sorry for missing context, @viirya . SPARK-43329 and SPARK-43342 were filed as a regression at Apache Spark 3.4.0 and those issues have the error message, I linked all the reported issues to the original JIRA which caused this regression.
And, the following was the reverting PR from the author of SPARK-39006, @dcoliversun. In short, while adding a log message, we missed a corner case which one NFS-backed PVC is mounted by multiple executors. So, we decide to revert SPARK-39006 because it doesn't give actual benefit (except logging). |
|
Thank you @dongjoon-hyun |
|
Thank you! |
…e for executor PVC dynamic allocation failure ### What changes were proposed in this pull request? This reverts commit b065c94. ### Why are the changes needed? To remove the regression from SPARK-39006. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes #41057 Closes #41069 from dongjoon-hyun/SPARK-43342. Authored-by: Qian.Sun <qian.sun2020@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 3ba1fa3) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Merged to master/3.4. |
…e for executor PVC dynamic allocation failure ### What changes were proposed in this pull request? This reverts commit b065c94. ### Why are the changes needed? To remove the regression from SPARK-39006. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#41057 Closes apache#41069 from dongjoon-hyun/SPARK-43342. Authored-by: Qian.Sun <qian.sun2020@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
…e for executor PVC dynamic allocation failure ### What changes were proposed in this pull request? This reverts commit b065c94. ### Why are the changes needed? To remove the regression from SPARK-39006. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#41057 Closes apache#41069 from dongjoon-hyun/SPARK-43342. Authored-by: Qian.Sun <qian.sun2020@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 3ba1fa3) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
…e for executor PVC dynamic allocation failure ### What changes were proposed in this pull request? This reverts commit b065c94. ### Why are the changes needed? To remove the regression from SPARK-39006. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#41057 Closes apache#41069 from dongjoon-hyun/SPARK-43342. Authored-by: Qian.Sun <qian.sun2020@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 3ba1fa3) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
…e for executor PVC dynamic allocation failure ### What changes were proposed in this pull request? This reverts commit b065c94. ### Why are the changes needed? To remove the regression from SPARK-39006. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#41057 Closes apache#41069 from dongjoon-hyun/SPARK-43342. Authored-by: Qian.Sun <qian.sun2020@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 3ba1fa3) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>

What changes were proposed in this pull request?
This reverts commit b065c94.
Why are the changes needed?
To remove the regression from SPARK-39006.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Closes #41057