Skip to content

Comments

[SPARK-43422][SQL] Keep tags on LogicalRelation with metadata output#41104

Closed
olaky wants to merge 2 commits intoapache:masterfrom
olaky:lost-tags-on-relations-with-metadata
Closed

[SPARK-43422][SQL] Keep tags on LogicalRelation with metadata output#41104
olaky wants to merge 2 commits intoapache:masterfrom
olaky:lost-tags-on-relations-with-metadata

Conversation

@olaky
Copy link
Contributor

@olaky olaky commented May 9, 2023

What changes were proposed in this pull request?

Maintain tags on LogicalRelation if that relation has metadata output

Why are the changes needed?

Tags were lost before when the Dataframe queries for a metadata column or SchemaPruning happened during optimization.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Added a new test

@github-actions github-actions bot added the SQL label May 9, 2023
@olaky
Copy link
Contributor Author

olaky commented May 9, 2023

Copy link
Contributor

@cloud-fan cloud-fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@olaky
Copy link
Contributor Author

olaky commented May 10, 2023

@cloud-fan tests passed after I fixed scalastyle

@HyukjinKwon HyukjinKwon changed the title [SPARK-43422] Keep tags on LogicalRelation with metadata output [SPARK-43422][SQL] Keep tags on LogicalRelation with metadata output May 10, 2023
@HyukjinKwon
Copy link
Member

Merged to master.

@olaky olaky deleted the lost-tags-on-relations-with-metadata branch May 10, 2023 08:33
LuciferYang pushed a commit to LuciferYang/spark that referenced this pull request May 10, 2023
### What changes were proposed in this pull request?

Maintain tags on LogicalRelation if that relation has metadata output

### Why are the changes needed?

Tags were lost before when the Dataframe queries for a metadata column or SchemaPruning happened during optimization.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Added a new test

Closes apache#41104 from olaky/lost-tags-on-relations-with-metadata.

Authored-by: Ole Sasse <ole.sasse@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants