[SPARK-43428] Move some class utils to common/utils#41109
Closed
amaliujia wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-43428] Move some class utils to common/utils#41109amaliujia wants to merge 2 commits intoapache:masterfrom
amaliujia wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
| */ | ||
| package org.apache.spark.util | ||
|
|
||
| object SparkClassUtils { |
Member
There was a problem hiding this comment.
This object name SparkClassUtils doesn't match with the file name, ClassUtils.scala.
hvanhovell
reviewed
May 10, 2023
| * Get the ClassLoader which loaded Spark. | ||
| */ | ||
| def getSparkClassLoader: ClassLoader = getClass.getClassLoader | ||
| def getSparkClassLoader: ClassLoader = SparkClassUtils.getSparkClassLoader |
Contributor
There was a problem hiding this comment.
You implement SparkClassUtils as a trait, and make Utils implement that trait. That will save you from writing a lot of code like this.
Contributor
Author
There was a problem hiding this comment.
This is a good idea.
Contributor
|
Merging. |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
May 10, 2023
### What changes were proposed in this pull request? This PR moves some commonly used class loader/reflection utils to common/utils. ### Why are the changes needed? Reduce the required dependency on Spark core. ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? Existing UT Closes apache#41109 from amaliujia/move_some_utils. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Herman van Hovell <herman@databricks.com>
Contributor
|
A late question: Should |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR moves some commonly used class loader/reflection utils to common/utils.
Why are the changes needed?
Reduce the required dependency on Spark core.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Existing UT