[SPARK-38469][CORE] Use error class in org.apache.spark.network #41140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
requested changes
May 11, 2023
core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Maxim Gekk <max.gekk@gmail.com>
MaxGekk
approved these changes
May 13, 2023
Member
|
Waiting for CI. |
Contributor
Author
|
CI test |
Member
|
@bozhang2820 Could you rebase on the recent master and re-trigger GAs, please. |
Member
|
Looking at the two last commit, seems like just flaky tests. Merging to master. Thank you, @bozhang2820. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to change exceptions created in package org.apache.spark.netrowk to use error class. This also adds an error class INTERNAL_ERROR_NETWORK and uses that for the internal errors in the package.
Why are the changes needed?
This is to move exceptions created in package org.apache.spark.network to error class.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.