[SPARK-43483][SQL][DOCS] Adds SQL references for OFFSET clause. #41151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beliefer
changed the title
Contributor
Author
|
ping @cloud-fan |
HyukjinKwon
approved these changes
May 15, 2023
cloud-fan
reviewed
May 15, 2023
| org.apache.spark.sql.AnalysisException: The limit expression must evaluate to a constant value ... | ||
| org.apache.spark.sql.AnalysisException | ||
| { | ||
| "errorClass" : "_LEGACY_ERROR_TEMP_2400", |
Contributor
There was a problem hiding this comment.
since we are documenting this error, can we assign an official error class name to it?
Contributor
There was a problem hiding this comment.
BTW, is this really what the end users will see? A JSON string?
cloud-fan
reviewed
May 15, 2023
|
|
||
| -- A non-foldable expression as an input to OFFSET is not allowed. | ||
| SELECT name, age FROM person ORDER BY name OFFSET length(name); | ||
| org.apache.spark.sql.AnalysisException |
cloud-fan
approved these changes
May 15, 2023
cloud-fan
approved these changes
May 15, 2023
Contributor
|
thanks, merging to master/3.4! |
cloud-fan
pushed a commit
that referenced
this pull request
May 15, 2023
### What changes were proposed in this pull request? Spark 3.4.0 released the new syntax: `OFFSET clause`. But the SQL reference missing the description for it. ### Why are the changes needed? Adds SQL reference for `OFFSET` clause. ### Does this PR introduce _any_ user-facing change? 'Yes'. Users could find out the SQL reference for `OFFSET` clause. ### How was this patch tested? Manual verify.     Closes #41151 from beliefer/SPARK-43483. Authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Contributor
Author
|
@cloud-fan @HyukjinKwon Thank you for all! |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? Spark 3.4.0 released the new syntax: `OFFSET clause`. But the SQL reference missing the description for it. ### Why are the changes needed? Adds SQL reference for `OFFSET` clause. ### Does this PR introduce _any_ user-facing change? 'Yes'. Users could find out the SQL reference for `OFFSET` clause. ### How was this patch tested? Manual verify.     Closes apache#41151 from beliefer/SPARK-43483. Authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
GladwinLee
pushed a commit
to lyft/spark
that referenced
this pull request
Oct 10, 2023
### What changes were proposed in this pull request? Spark 3.4.0 released the new syntax: `OFFSET clause`. But the SQL reference missing the description for it. ### Why are the changes needed? Adds SQL reference for `OFFSET` clause. ### Does this PR introduce _any_ user-facing change? 'Yes'. Users could find out the SQL reference for `OFFSET` clause. ### How was this patch tested? Manual verify.     Closes apache#41151 from beliefer/SPARK-43483. Authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Oct 10, 2023
### What changes were proposed in this pull request? Spark 3.4.0 released the new syntax: `OFFSET clause`. But the SQL reference missing the description for it. ### Why are the changes needed? Adds SQL reference for `OFFSET` clause. ### Does this PR introduce _any_ user-facing change? 'Yes'. Users could find out the SQL reference for `OFFSET` clause. ### How was this patch tested? Manual verify.     Closes apache#41151 from beliefer/SPARK-43483. Authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Spark 3.4.0 released the new syntax:
OFFSET clause.But the SQL reference missing the description for it.
Why are the changes needed?
Adds SQL reference for
OFFSETclause.Does this PR introduce any user-facing change?
'Yes'.
Users could find out the SQL reference for
OFFSETclause.How was this patch tested?
Manual verify.
