[SPARK-43580][PYTHON][TESTS] Add https://dlcdn.apache.org/ to default_sites of get_preferred_mirrors#41222
Closed
dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:SPARK-43580
Closed
[SPARK-43580][PYTHON][TESTS] Add https://dlcdn.apache.org/ to default_sites of get_preferred_mirrors#41222dongjoon-hyun wants to merge 2 commits intoapache:masterfrom dongjoon-hyun:SPARK-43580
https://dlcdn.apache.org/ to default_sites of get_preferred_mirrors#41222dongjoon-hyun wants to merge 2 commits intoapache:masterfrom
dongjoon-hyun:SPARK-43580
Conversation
…_sites of get_preferred_mirrors
HyukjinKwon
approved these changes
May 18, 2023
Member
Author
|
Thank you! |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…lt_sites of get_preferred_mirrors ### What changes were proposed in this pull request? This PR aims to add `https://dlcdn.apache.org/` to the default mirror site list during python installation tests. ### Why are the changes needed? This is a preferred mirror. So, even if `https://www.apache.org/dyn/closer.lua` is inaccessible, we will download from `https://dlcdn.apache.org/`. ``` $ curl https://www.apache.org/dyn/closer.lua\?preferred\=true https://dlcdn.apache.org/ ``` Although we try to get this programmatically, sometimes `https://www.apache.org/dyn/closer.lua` seems to fail. https://github.com/apache/spark/blob/acad77d56112f2cab2ce5adca913b75ce659add5/python/pyspark/install.py#L169C2-L179 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#41222 from dongjoon-hyun/SPARK-43580. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
https://dlcdn.apache.org/to the default mirror site list during python installation tests.Why are the changes needed?
This is a preferred mirror. So, even if
https://www.apache.org/dyn/closer.luais inaccessible, we will download fromhttps://dlcdn.apache.org/.Although we try to get this programmatically, sometimes
https://www.apache.org/dyn/closer.luaseems to fail.https://github.com/apache/spark/blob/acad77d56112f2cab2ce5adca913b75ce659add5/python/pyspark/install.py#L169C2-L179
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.