[SPARK-43589][SQL][3.3] Fix cannotBroadcastTableOverMaxTableBytesError to use bytesToString#41234
Closed
dongjoon-hyun wants to merge 1 commit intoapache:branch-3.3from
dongjoon-hyun:SPARK-43589-3.3
Closed
[SPARK-43589][SQL][3.3] Fix cannotBroadcastTableOverMaxTableBytesError to use bytesToString#41234dongjoon-hyun wants to merge 1 commit intoapache:branch-3.3from dongjoon-hyun:SPARK-43589-3.3
cannotBroadcastTableOverMaxTableBytesError to use bytesToString#41234dongjoon-hyun wants to merge 1 commit intoapache:branch-3.3from
dongjoon-hyun:SPARK-43589-3.3
Conversation
…or` to use `bytesToString`
LuciferYang
approved these changes
May 19, 2023
Member
Author
|
Thank you again, @LuciferYang ! Merged to branch-3.3. |
dongjoon-hyun
added a commit
that referenced
this pull request
May 19, 2023
…or` to use `bytesToString` ### What changes were proposed in this pull request? This is a logical backporting of #41232 This PR aims to fix `cannotBroadcastTableOverMaxTableBytesError` to use `bytesToString` instead of shift operations. ### Why are the changes needed? To avoid user confusion by giving more accurate values. For example, `maxBroadcastTableBytes` is 1GB and `dataSize` is `2GB - 1 byte`. **BEFORE** ``` Cannot broadcast the table that is larger than 1GB: 1 GB. ``` **AFTER** ``` Cannot broadcast the table that is larger than 1024.0 MiB: 2048.0 MiB. ``` ### Does this PR introduce _any_ user-facing change? Yes, but only error message. ### How was this patch tested? Pass the CIs with newly added test case. Closes #41234 from dongjoon-hyun/SPARK-43589-3.3. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a logical backporting of #41232
This PR aims to fix
cannotBroadcastTableOverMaxTableBytesErrorto usebytesToStringinstead of shift operations.Why are the changes needed?
To avoid user confusion by giving more accurate values. For example,
maxBroadcastTableBytesis 1GB anddataSizeis2GB - 1 byte.BEFORE
AFTER
Does this PR introduce any user-facing change?
Yes, but only error message.
How was this patch tested?
Pass the CIs with newly added test case.