[SPARK-43830][BUILD] Update scalatest and scalatestplus related dependencies to newest version#41341
Closed
panbingkun wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-43830][BUILD] Update scalatest and scalatestplus related dependencies to newest version#41341panbingkun wants to merge 2 commits intoapache:masterfrom
panbingkun wants to merge 2 commits intoapache:masterfrom
Conversation
…dencies to newest version
panbingkun
commented
May 27, 2023
| .setAppName("test") | ||
| .set(DYN_ALLOCATION_TESTING, true) | ||
| sc = spy(new SparkContext(conf)) | ||
| sc = spy[SparkContext](new SparkContext(conf)) |
Contributor
Author
There was a problem hiding this comment.
Why change it? The following error will be reported if not changed:
panbingkun
commented
May 27, 2023
|
|
||
| val map: java.util.Map[Double, String] = spy(JavaUtils.mapAsSerializableJavaMap(src)) | ||
| val map: java.util.Map[Double, String] = spy[SerializableMapWrapper[Double, String]]( | ||
| JavaUtils.mapAsSerializableJavaMap(src)) |
…dencies to newest version
panbingkun
commented
May 27, 2023
| netty-transport-native-unix-common/4.1.92.Final//netty-transport-native-unix-common-4.1.92.Final.jar | ||
| netty-transport/4.1.92.Final//netty-transport-4.1.92.Final.jar | ||
| objenesis/3.2//objenesis-3.2.jar | ||
| objenesis/3.3//objenesis-3.3.jar |
Contributor
Author
There was a problem hiding this comment.
Change brought about by mockito version change
srowen
approved these changes
May 27, 2023
Member
|
Just need to get the test to re-run and pass but looking OK |
Member
|
Merged to master |
Contributor
|
@panbingkun when I do local test, I found the following issues: then and when I revert this one, all test passed. Also cc @srowen @dongjoon-hyun |
Contributor
Author
|
Let me check it! @LuciferYang @srowen @dongjoon-hyun |
srowen
pushed a commit
that referenced
this pull request
May 31, 2023
…ated dependencies to newest version ### What changes were proposed in this pull request? The pr aims to follow up PR: #41341 ### Why are the changes needed? Fix issue which caused by inconsistent versions of `bytebuddy` that `selenium` and `mockito-core` rely on. 1.mockito-core depend on `bytebuddy` 1.12.19 <img width="491" alt="image" src="https://github.com/apache/spark/assets/15246973/62dbed8c-3164-4337-8d67-a4eb371312bd"> https://github.com/mockito/mockito/blob/v4.11.0/gradle/dependencies.gradle#L7 2.selenium depend on `bytebuddy` 1.14.4 https://github.com/SeleniumHQ/selenium/blob/selenium-4.9.1/java/maven_deps.bzl#L81 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - Manual testing: (base) panbingkun:~/Developer/spark/spark-community$build/sbt "connect/test" ... [info] - function_raise_error (2 milliseconds) [info] - column_when_otherwise (4 milliseconds) [info] - function_date_trunc (4 milliseconds) [info] Run completed in 21 seconds, 249 milliseconds. [info] Total number of tests run: 576 [info] Suites: completed 12, aborted 0 [info] Tests: succeeded 576, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. [success] Total time: 77 s (01:17), completed May 29, 2023 4:45:57 PM - Pass GA Closes #41364 from panbingkun/SPARK-43830. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Sean Owen <srowen@gmail.com>
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
…dencies to newest version ### What changes were proposed in this pull request? The pr aims to update scalatest and scalatestplus related dependencies to newest version, include: This pr aims upgrade `scalatest` related test dependencies to 3.2.16: - scalatest: upgrade scalatest from 3.2.15 to 3.2.16 - mockito - mockito-core: upgrade from 4.6.1 to 4.11.0 - mockito-inline: upgrade from 4.6.1 to 4.11.0 - selenium-java: upgrade from 4.7.2 to 4.9.1 - htmlunit-driver: upgrade from 4.7.2 to 4.9.1 - htmlunit: upgrade from 2.67.0 to 2.70.0 - scalatestplus - scalacheck-1-17: upgrade from 3.2.15.0 to 3.2.16.0 - mockito: upgrade from `mockito-4-6` 3.2.15.0 to `mockito-4-11` 3.2.16.0 - selenium: upgrade from `selenium-4-7` 3.2.15.0 to `selenium-4-9` 3.2.16.0 ### Why are the changes needed? The relevant release notes as follows: - scalatest: - https://github.com/scalatest/scalatest/releases/tag/release-3.2.16 - [mockito](https://github.com/mockito/mockito) - https://github.com/mockito/mockito/releases/tag/v4.11.0 - https://github.com/mockito/mockito/releases/tag/v4.10.0 - https://github.com/mockito/mockito/releases/tag/v4.9.0 - https://github.com/mockito/mockito/releases/tag/v4.8.1 - https://github.com/mockito/mockito/releases/tag/v4.8.0 - https://github.com/mockito/mockito/releases/tag/v4.7.0 - [selenium-java](https://github.com/SeleniumHQ/selenium) - https://github.com/SeleniumHQ/selenium/releases/tag/selenium-4.9.1 - https://github.com/SeleniumHQ/selenium/releases/tag/selenium-4.9.0 - https://github.com/SeleniumHQ/selenium/releases/tag/selenium-4.8.3-java - https://github.com/SeleniumHQ/selenium/releases/tag/selenium-4.8.2-java - https://github.com/SeleniumHQ/selenium/releases/tag/selenium-4.8.1 - https://github.com/SeleniumHQ/selenium/releases/tag/selenium-4.8.0 - [htmlunit-driver](https://github.com/SeleniumHQ/htmlunit-driver) - https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/htmlunit-driver-4.9.1 - https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/htmlunit-driver-4.9.0 - https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/htmlunit-driver-4.8.3 - https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/htmlunit-driver-4.8.1.1 - https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/4.8.1 - https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/4.8.0 - [htmlunit](https://github.com/HtmlUnit/htmlunit) - https://github.com/HtmlUnit/htmlunit/releases/tag/2.70.0 - Why this version: because the 4.9.1 version of Selenium relies on it. https://github.com/SeleniumHQ/selenium/blob/selenium-4.9.1/java/maven_deps.bzl#L83 - [org.scalatestplus:scalacheck-1-17](https://github.com/scalatest/scalatestplus-scalacheck) - https://github.com/scalatest/scalatestplus-scalacheck/releases/tag/release-3.2.16.0-for-scalacheck-1.17 - [org.scalatestplus:mockito-4-11](https://github.com/scalatest/scalatestplus-mockito) - https://github.com/scalatest/scalatestplus-mockito/releases/tag/release-3.2.16.0-for-mockito-4.11 - [org.scalatestplus:selenium-4-9](https://github.com/scalatest/scalatestplus-selenium) - https://github.com/scalatest/scalatestplus-selenium/releases/tag/release-3.2.16.0-for-selenium-4.9 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - Pass GitHub Actions - Manual test: - ChromeUISeleniumSuite - RocksDBBackendChromeUIHistoryServerSuite ``` build/sbt -Dguava.version=31.1-jre -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver -Dtest.default.exclude.tags="" -Phive -Phive-thriftserver "core/testOnly org.apache.spark.ui.ChromeUISeleniumSuite" build/sbt -Dguava.version=31.1-jre -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver -Dtest.default.exclude.tags="" -Phive -Phive-thriftserver "core/testOnly org.apache.spark.deploy.history.RocksDBBackendChromeUIHistoryServerSuite" ``` <img width="856" alt="image" src="https://github.com/apache/spark/assets/15246973/73349ffb-4198-4371-a741-411712d14712"> Closes apache#41341 from panbingkun/upgrade_scalatest. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Sean Owen <srowen@gmail.com>
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
…ated dependencies to newest version ### What changes were proposed in this pull request? The pr aims to follow up PR: apache#41341 ### Why are the changes needed? Fix issue which caused by inconsistent versions of `bytebuddy` that `selenium` and `mockito-core` rely on. 1.mockito-core depend on `bytebuddy` 1.12.19 <img width="491" alt="image" src="https://github.com/apache/spark/assets/15246973/62dbed8c-3164-4337-8d67-a4eb371312bd"> https://github.com/mockito/mockito/blob/v4.11.0/gradle/dependencies.gradle#L7 2.selenium depend on `bytebuddy` 1.14.4 https://github.com/SeleniumHQ/selenium/blob/selenium-4.9.1/java/maven_deps.bzl#L81 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - Manual testing: (base) panbingkun:~/Developer/spark/spark-community$build/sbt "connect/test" ... [info] - function_raise_error (2 milliseconds) [info] - column_when_otherwise (4 milliseconds) [info] - function_date_trunc (4 milliseconds) [info] Run completed in 21 seconds, 249 milliseconds. [info] Total number of tests run: 576 [info] Suites: completed 12, aborted 0 [info] Tests: succeeded 576, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. [success] Total time: 77 s (01:17), completed May 29, 2023 4:45:57 PM - Pass GA Closes apache#41364 from panbingkun/SPARK-43830. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Sean Owen <srowen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to update scalatest and scalatestplus related dependencies to newest version, include:
This pr aims upgrade
scalatestrelated test dependencies to 3.2.16:scalatest: upgrade scalatest from 3.2.15 to 3.2.16
mockito
selenium-java: upgrade from 4.7.2 to 4.9.1
htmlunit-driver: upgrade from 4.7.2 to 4.9.1
htmlunit: upgrade from 2.67.0 to 2.70.0
scalatestplus
mockito-4-63.2.15.0 tomockito-4-113.2.16.0selenium-4-73.2.15.0 toselenium-4-93.2.16.0Why are the changes needed?
The relevant release notes as follows:
scalatest:
mockito
selenium-java
htmlunit-driver
htmlunit
org.scalatestplus:scalacheck-1-17
org.scalatestplus:mockito-4-11
org.scalatestplus:selenium-4-9
Does this PR introduce any user-facing change?
No.
How was this patch tested?