[SPARK-43845][INFRA] Setup Scala 2.12 Daily GitHub Action Job#41354
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-43845
Closed
[SPARK-43845][INFRA] Setup Scala 2.12 Daily GitHub Action Job#41354dongjoon-hyun wants to merge 1 commit intoapache:masterfrom dongjoon-hyun:SPARK-43845
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-43845
Conversation
Member
Author
|
Could you review this too, @HyukjinKwon ? |
yaooqinn
approved these changes
May 29, 2023
LuciferYang
approved these changes
May 29, 2023
Member
Author
|
Thank you, @yaooqinn and @LuciferYang . |
Member
|
Should probably hold on making Scala 2.13 by default for now. it'd be a breaking change to the end users of using |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
### What changes were proposed in this pull request? This PR aims to setup Scala 2.12 Daily GitHub Action Job by converting Scala 2.13 Daily Job. - Rename `build_scala213.yml` file to `.github/workflows/build_scala212.yml`. - Rename job name ``` -name: "Build (master, Scala 2.13, Hadoop 3, JDK 8)" +name: "Build (master, Scala 2.12, Hadoop 3, JDK 8)" ``` - Switch SCALA_PROFILE from `scala2.13` to `scala2.12`. ### Why are the changes needed? To keep the Scala 2.12 test coverage ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? This is a daily job. We need to check after merging. Closes apache#41354 from dongjoon-hyun/SPARK-43845. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to setup Scala 2.12 Daily GitHub Action Job by converting Scala 2.13 Daily Job.
build_scala213.ymlfile to.github/workflows/build_scala212.yml.scala2.13toscala2.12.Why are the changes needed?
To keep the Scala 2.12 test coverage
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This is a daily job. We need to check after merging.