Skip to content

[SPARK-43859][SQL] Override toString in LateralColumnAliasReference#41359

Closed
wangyum wants to merge 1 commit into
apache:masterfrom
wangyum:SPARK-43859
Closed

[SPARK-43859][SQL] Override toString in LateralColumnAliasReference#41359
wangyum wants to merge 1 commit into
apache:masterfrom
wangyum:SPARK-43859

Conversation

@wangyum
Copy link
Copy Markdown
Member

@wangyum wangyum commented May 29, 2023

What changes were proposed in this pull request?

This PR makes it override toString in LateralColumnAliasReference.

Why are the changes needed?

Improve the readability of logical plans.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manual test:

select id + 1 as a1, a1 + 2 as a3 from range(10);

Before this PR:

Project [(id#2L + 1) AS a1#0, (lateralAliasReference('a1, a1, 'a1) + 2) AS a3#1]
+- Range (0, 10, step=1, splits=None)

After this PR:

Project [(id#2L + 1) AS a1#0, (lateralAliasReference(a1) + 2) AS a3#1]
+- Range (0, 10, step=1, splits=None)

@github-actions github-actions Bot added the SQL label May 29, 2023
@wangyum
Copy link
Copy Markdown
Member Author

wangyum commented May 30, 2023

@anchovYu @cloud-fan

@wangyum wangyum closed this in 6fa910b May 31, 2023
@wangyum
Copy link
Copy Markdown
Member Author

wangyum commented May 31, 2023

Merged to master.

@wangyum wangyum deleted the SPARK-43859 branch May 31, 2023 05:12
czxm pushed a commit to czxm/spark that referenced this pull request Jun 12, 2023
### What changes were proposed in this pull request?

This PR makes it override `toString` in `LateralColumnAliasReference`.

### Why are the changes needed?

Improve the readability of logical plans.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manual test:
```sql
select id + 1 as a1, a1 + 2 as a3 from range(10);
```
Before this PR:
```
Project [(id#2L + 1) AS a1#0, (lateralAliasReference('a1, a1, 'a1) + 2) AS a3#1]
+- Range (0, 10, step=1, splits=None)
```

After this  PR:
```
Project [(id#2L + 1) AS a1#0, (lateralAliasReference(a1) + 2) AS a3#1]
+- Range (0, 10, step=1, splits=None)
```

Closes apache#41359 from wangyum/SPARK-43859.

Authored-by: Yuming Wang <yumwang@ebay.com>
Signed-off-by: Yuming Wang <yumwang@ebay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants