[SPARK-43081][ML][FOLLOW-UP] Improve torch distributor data loader code#41382
Closed
WeichenXu123 wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-43081][ML][FOLLOW-UP] Improve torch distributor data loader code#41382WeichenXu123 wants to merge 3 commits intoapache:masterfrom
WeichenXu123 wants to merge 3 commits intoapache:masterfrom
Conversation
zhengruifeng
approved these changes
May 30, 2023
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
### What changes were proposed in this pull request? ### Why are the changes needed? Improve torch distributor data loader code: * Add a verification that num_processes must match input spark dataframe partitions. This makes user debug easier when they set mismatched input dataframe, otherwise torch package will raise intricate error information. * Improve column value conversion in torch dataloader. Avoid comparing type operation for every column values. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? UT. Closes apache#41382 from WeichenXu123/improve-torch-dataloader. Authored-by: Weichen Xu <weichen.xu@databricks.com> Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Improve torch distributor data loader code:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.