improve the readability of SparkContext.scala #414
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
|
Thanks for submitting this. I see what you are trying to accomplish (by putting inits into a start method). However, I'm not sure if it actually improves readability when we pull the so far away from where they are initialized ... |
Contributor
Author
|
From the side of the life cycle for component, only stop method is incomplete, and the initialize code , start code written separately is better |
pwendell
pushed a commit
to pwendell/spark
that referenced
this pull request
May 12, 2014
Code clean up for mllib * Removed unnecessary parentheses * Removed unused imports * Simplified `filter...size()` to `count ...` * Removed obsoleted parameters' comments
andrewor14
pushed a commit
to andrewor14/spark
that referenced
this pull request
Jan 8, 2015
Code clean up for mllib * Removed unnecessary parentheses * Removed unused imports * Simplified `filter...size()` to `count ...` * Removed obsoleted parameters' comments (cherry picked from commit 84595ea) Signed-off-by: Patrick Wendell <pwendell@gmail.com>
mccheah
pushed a commit
to mccheah/spark
that referenced
this pull request
Nov 28, 2018
bzhaoopenstack
pushed a commit
to bzhaoopenstack/spark
that referenced
this pull request
Sep 11, 2019
…bs (apache#414) After testing, we don't need to set "DISABLE_HTTPD_MOD_WSGI" to true for docker machine + devstack jobs and only need to add the '/v3' postfix if AUTH_URL doesn't include it. This can avoid the SSH failure problem. Closes: theopenlab/openlab#168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.