[SPARK-43760][SQL][3.4] Nullability of scalar subquery results#41408
Closed
agubichev wants to merge 3 commits into
Closed
[SPARK-43760][SQL][3.4] Nullability of scalar subquery results#41408agubichev wants to merge 3 commits into
agubichev wants to merge 3 commits into
Conversation
Contributor
Author
HyukjinKwon
changed the title
cloud-fan
approved these changes
Jun 1, 2023
Contributor
|
thanks, merging to 3.4! |
cloud-fan
pushed a commit
that referenced
this pull request
Jun 1, 2023
### What changes were proposed in this pull request? Backport of #41287. Makes sure that the results of scalar subqueries are declared as nullable. ### Why are the changes needed? This is an existing correctness bug, see https://issues.apache.org/jira/browse/SPARK-43760 ### Does this PR introduce _any_ user-facing change? Fixes a correctness issue, so it is user-facing. ### How was this patch tested? Query tests. Closes #41408 from agubichev/spark-43760-nullability-branch-3.4. Authored-by: Andrey Gubichev <andrey.gubichev@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Member
|
Thank you, @agubichev and @cloud-fan ! |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? Backport of apache#41287. Makes sure that the results of scalar subqueries are declared as nullable. ### Why are the changes needed? This is an existing correctness bug, see https://issues.apache.org/jira/browse/SPARK-43760 ### Does this PR introduce _any_ user-facing change? Fixes a correctness issue, so it is user-facing. ### How was this patch tested? Query tests. Closes apache#41408 from agubichev/spark-43760-nullability-branch-3.4. Authored-by: Andrey Gubichev <andrey.gubichev@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit a2c915d) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
GladwinLee
pushed a commit
to lyft/spark
that referenced
this pull request
Oct 10, 2023
### What changes were proposed in this pull request? Backport of apache#41287. Makes sure that the results of scalar subqueries are declared as nullable. ### Why are the changes needed? This is an existing correctness bug, see https://issues.apache.org/jira/browse/SPARK-43760 ### Does this PR introduce _any_ user-facing change? Fixes a correctness issue, so it is user-facing. ### How was this patch tested? Query tests. Closes apache#41408 from agubichev/spark-43760-nullability-branch-3.4. Authored-by: Andrey Gubichev <andrey.gubichev@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Oct 10, 2023
### What changes were proposed in this pull request? Backport of apache#41287. Makes sure that the results of scalar subqueries are declared as nullable. ### Why are the changes needed? This is an existing correctness bug, see https://issues.apache.org/jira/browse/SPARK-43760 ### Does this PR introduce _any_ user-facing change? Fixes a correctness issue, so it is user-facing. ### How was this patch tested? Query tests. Closes apache#41408 from agubichev/spark-43760-nullability-branch-3.4. Authored-by: Andrey Gubichev <andrey.gubichev@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Backport of #41287.
Makes sure that the results of scalar subqueries are declared as nullable.
Why are the changes needed?
This is an existing correctness bug, see https://issues.apache.org/jira/browse/SPARK-43760
Does this PR introduce any user-facing change?
Fixes a correctness issue, so it is user-facing.
How was this patch tested?
Query tests.