[SPARK-43910][SQL] Strip __auto_generated_subquery_name from ids in errors#41411
Closed
MaxGekk wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-43910][SQL] Strip __auto_generated_subquery_name from ids in errors#41411MaxGekk wants to merge 2 commits intoapache:masterfrom
__auto_generated_subquery_name from ids in errors#41411MaxGekk wants to merge 2 commits intoapache:masterfrom
Conversation
HyukjinKwon
approved these changes
Jun 1, 2023
MaxGekk
changed the title
__auto_generated_subquery_name from ids in errors__auto_generated_subquery_name from ids in errors
Member
Author
cloud-fan
approved these changes
Jun 1, 2023
Member
Author
|
Merging to master. Thank you, @HyukjinKwon @cloud-fan for review. |
Contributor
|
Belated lgtm from me too. Thanks for this change. |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
… errors ### What changes were proposed in this pull request? In the PR, I propose the drop the prefix `__auto_generated_subquery_name` from SQL ids in errors. ### Why are the changes needed? The changes should improve user experience with Spark SQL by making error messages shorter and more clear. ### Does this PR introduce _any_ user-facing change? Should not. ### How was this patch tested? By running the affected test suites: ``` $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite" $ build/sbt "test:testOnly *QueryCompilationErrorsSuite" $ build/sbt "sql/testOnly *QueryExecutionErrorsSuite" ``` Closes apache#41411 from MaxGekk/strip__auto_generated_subquery_name. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose the drop the prefix
__auto_generated_subquery_namefrom SQL ids in errors.Why are the changes needed?
The changes should improve user experience with Spark SQL by making error messages shorter and more clear.
Does this PR introduce any user-facing change?
Should not.
How was this patch tested?
By running the affected test suites: