[SPARK-44010][PYTHON][SS][MINOR] Python StreamingQueryProgress rowsPerSecond type fix#41522
Closed
WweiL wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-44010][PYTHON][SS][MINOR] Python StreamingQueryProgress rowsPerSecond type fix#41522WweiL wants to merge 2 commits intoapache:masterfrom
WweiL wants to merge 2 commits intoapache:masterfrom
Conversation
HyukjinKwon
approved these changes
Jun 9, 2023
HyukjinKwon
changed the title
Member
|
Merged to master. |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
…rSecond type fix ### What changes were proposed in this pull request? Fix Python StreamingQueryProgress' inputRowsPerSecond and processedRowsPerSecond's return type. They should be float according to `org/apache/spark/sql/streaming/progress.scala`. Also lifted initialization of the two values to initializer, to align with the implementation of `SourceProgress` ### Why are the changes needed? Better typed API ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing unit tests Closes apache#41522 from WweiL/SPARK-44010-sqp-type-fix. Authored-by: Wei Liu <wei.liu@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix Python StreamingQueryProgress' inputRowsPerSecond and processedRowsPerSecond's return type. They should be float according to
org/apache/spark/sql/streaming/progress.scala. Also lifted initialization of the two values to initializer, to align with the implementation ofSourceProgressWhy are the changes needed?
Better typed API
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit tests