Skip to content

[SPARK-5297][Streaming][backport] Backport SPARK-5297 to Spark 1.2 #4154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jerryshao wants to merge 3 commits into from
Closed

[SPARK-5297][Streaming][backport] Backport SPARK-5297 to Spark 1.2 #4154

jerryshao wants to merge 3 commits into from

Conversation

@jerryshao
Copy link
Contributor

@jerryshao jerryshao commented Jan 22, 2015

No description provided.

@SparkQA
Copy link

SparkQA commented Jan 22, 2015

Test build #25939 has started for PR 4154 at commit a91f295.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 22, 2015

Test build #25939 has finished for PR 4154 at commit a91f295.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 22, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25939/
Test FAILed.

@jerryshao
Copy link
Contributor Author

jerryshao commented Jan 22, 2015

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jan 22, 2015

Test build #25942 has started for PR 4154 at commit a91f295.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 22, 2015

Test build #25942 has finished for PR 4154 at commit a91f295.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 22, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25942/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Jan 22, 2015

Test build #25945 has started for PR 4154 at commit a4b2bea.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 22, 2015

Test build #25945 has finished for PR 4154 at commit a4b2bea.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 22, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25945/
Test FAILed.

@jerryshao
Copy link
Contributor Author

jerryshao commented Jan 22, 2015

Quite strange the test is OK in my local test but failed in Jenkins.

@jerryshao
Copy link
Contributor Author

jerryshao commented Jan 22, 2015

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jan 22, 2015

Test build #25954 has started for PR 4154 at commit a4b2bea.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 22, 2015

Test build #25954 has finished for PR 4154 at commit a4b2bea.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 22, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25954/
Test FAILed.

@jerryshao
Copy link
Contributor Author

jerryshao commented Jan 26, 2015

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jan 26, 2015

Test build #26074 has started for PR 4154 at commit a4b2bea.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 26, 2015

Test build #26074 has finished for PR 4154 at commit a4b2bea.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 26, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26074/
Test PASSed.

@jerryshao
Copy link
Contributor Author

jerryshao commented Jan 26, 2015

Hi @pwendell , would you mind taking a look at this backport PR, thanks a lot.

@tdas
Copy link
Contributor

tdas commented Jan 28, 2015

@jerryshao We generally dont make binary compatibility changes within patch releases. So I dont think this is a good idea. If there is a way this fix can be made without breaking binary compatibility, I can consider merging.

@srowen
Copy link
Member

srowen commented Feb 27, 2015

@jerryshao Given the comment from @tdas, let's close this PR and not merge this change into 1.2.x. I think that's prudent.

@jerryshao
Copy link
Contributor Author

jerryshao commented Feb 27, 2015

OK, I will close this PR, thanks a lot for your comments.

@jerryshao jerryshao closed this Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jerryshao @SparkQA @AmplabJenkins @tdas @srowen