Skip to content

[SPARK-44181][BUILD] Upgrade Apache Kafka to 3.4.1#41727

Closed
bjornjorgensen wants to merge 2 commits intoapache:masterfrom
bjornjorgensen:kafka-3.5
Closed

[SPARK-44181][BUILD] Upgrade Apache Kafka to 3.4.1#41727
bjornjorgensen wants to merge 2 commits intoapache:masterfrom
bjornjorgensen:kafka-3.5

Conversation

@bjornjorgensen
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Upgrade Apache Kafka from 3.4.0 to 3.4.1

Why are the changes needed?

Release Notes

Kafka 3.4.1 fixes 58 issues since the 3.4.0 release.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA

@github-actions github-actions bot added the BUILD label Jun 25, 2023
@bjornjorgensen
Copy link
Copy Markdown
Contributor Author

@dongjoon-hyun This is not the latest version. There are a 3.5.0 but that did not run as I was hoping for see my first commit.
Can we have this for spark 3.4.2 ?

@dongjoon-hyun
Copy link
Copy Markdown
Member

Thank you for pinging me.

@bjornjorgensen
Copy link
Copy Markdown
Contributor Author

This https://github.com/bjornjorgensen/spark/actions/runs/5365767358/jobs/9734794773 is the build log for 3.5.0 any tips on whats wrong her?

Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CIs).

@dongjoon-hyun
Copy link
Copy Markdown
Member

Ur, do you mean this will not pass CI?

@bjornjorgensen
Copy link
Copy Markdown
Contributor Author

This 3.4.1 will pass CI but kafka 3.5.0 did not.

@bjornjorgensen
Copy link
Copy Markdown
Contributor Author

oh... in 3.5.0 kafka have moved many modules.
[KAFKA-14472] - Move TransactionIndex and related to storage module
[KAFKA-14473] - Move AbstractIndex to storage module
[KAFKA-14474] - Move OffsetIndex to storage module
[KAFKA-14475] - Move TimeIndex/LazyIndex to storage module
[KAFKA-14476] - Move OffsetMap to storage module
[KAFKA-14477] - Move LogValidator and related to storage module
[KAFKA-14478] - Move LogConfig/CleanerConfig to storage module
[KAFKA-14480] - Move ProducerStateManager to storage module

https://github.com/bjornjorgensen/spark/actions/runs/5365767358/jobs/9734794665#step:7:2031

@dongjoon-hyun
Copy link
Copy Markdown
Member

Merged to master. Could you make a backporting PR for branch-3.4, @bjornjorgensen ?

@bjornjorgensen
Copy link
Copy Markdown
Contributor Author

@dongjoon-hyun Thank you.
Yes, I can try tomorrow.

@dongjoon-hyun
Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants