Skip to content

Comments

[SPARK-44202][CORE] Add JobTag APIs to JavaSparkContext#41753

Closed
HyukjinKwon wants to merge 2 commits intoapache:masterfrom
HyukjinKwon:SPARK-44202
Closed

[SPARK-44202][CORE] Add JobTag APIs to JavaSparkContext#41753
HyukjinKwon wants to merge 2 commits intoapache:masterfrom
HyukjinKwon:SPARK-44202

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jun 27, 2023

What changes were proposed in this pull request?

This PR proposes to add:

  • SparkContext.setInterruptOnCancel(interruptOnCancel: Boolean): Unit
  • SparkContext.addJobTag(tag: String): Unit
  • SparkContext.removeJobTag(tag: String): Unit
  • SparkContext.getJobTags(): Set[String]
  • SparkContext.clearJobTags(): Unit
  • SparkContext.cancelJobsWithTag(tag: String): Unit

into Java API.

Why are the changes needed?

For Java users. In addition, these will be used in Python implementation in SPARK-44194

Does this PR introduce any user-facing change?

Yes, it adds new API in Java.

How was this patch tested?

It's an alias so no tests added. These will be at least called once via PySpark when I work on SPARK-44194 so I don't worry about it too much.

@github-actions github-actions bot added the CORE label Jun 27, 2023
@HyukjinKwon
Copy link
Member Author

cc @juliuszsompolski @hvanhovell FYI

Copy link
Contributor

@hvanhovell hvanhovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@yaooqinn yaooqinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyukjinKwon
Copy link
Member Author

Related tests all passed.

Merged to master.

Copy link
Contributor

@juliuszsompolski juliuszsompolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

* are actually stopped in a timely manner, but is off by default due to HDFS-1208, where HDFS
* may respond to Thread.interrupt() by marking nodes as dead.
*
* @since 3.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HyukjinKwon HyukjinKwon deleted the SPARK-44202 branch January 15, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants