[SPARK-44271][SQL] Move default values functions from StructType to ResolveDefaultColumns#41820
Closed
amaliujia wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-44271][SQL] Move default values functions from StructType to ResolveDefaultColumns#41820amaliujia wants to merge 4 commits intoapache:masterfrom
amaliujia wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
R: @cloud-fan |
amaliujia
changed the title
cloud-fan
approved these changes
Jul 3, 2023
amaliujia
force-pushed
the
clean_up_left_errors
branch
from
b82a0c6 to
2e9daec
Compare
dtenedor
approved these changes
Jul 5, 2023
dtenedor
approved these changes
Jul 5, 2023
Contributor
There was a problem hiding this comment.
This does not appear to cache the results of each method, as this comment suggests. The previous code did this with a lazy val. Can you update the comment to mention that these results are not cached and that callers should take care to avoid calling them repeatedly in tight loops during query execution (e.g. per-row) and instead prefer to initialize them as infrequently as possible, preferably only once?
amaliujia
force-pushed
the
clean_up_left_errors
branch
from
79483ad to
fe710eb
Compare
Contributor
|
Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move default values functions from StructType to ResolveDefaultColumns.
Why are the changes needed?
To simply DataType interface.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing test