[SPARK-44342][SQL] Replace SQLContext with SparkSession for GenTPCDSData #41900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ping @cloud-fan cc @maropu |
yaooqinn
approved these changes
Jul 10, 2023
Member
|
thanks, merged to master |
Contributor
Author
|
@yaooqinn @oss-maker Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
SQLContextis an old API for Spark SQL.But
GenTPCDSDatastill use it directly.Why are the changes needed?
Avoid use the legacy API for
GenTPCDSData.Does this PR introduce any user-facing change?
'No'.
Just update the benchmark utils.
How was this patch tested?
Manual test by running:
build/sbt "sql/Test/runMain org.apache.spark.sql.GenTPCDSData --dsdgenDir ... --location ... --scaleFactor 1"