Skip to content

[SPARK-44320][SQL] Assign names to the error class _LEGACY_ERROR_TEMP_[1067,1150,1220,1265,1277]#41909

Closed
panbingkun wants to merge 8 commits intoapache:masterfrom
panbingkun:SPARK-44320
Closed

[SPARK-44320][SQL] Assign names to the error class _LEGACY_ERROR_TEMP_[1067,1150,1220,1265,1277]#41909
panbingkun wants to merge 8 commits intoapache:masterfrom
panbingkun:SPARK-44320

Conversation

@panbingkun
Copy link
Contributor

What changes were proposed in this pull request?

The pr aims to assign names to the error class, include:

  • _LEGACY_ERROR_TEMP_1067 => UNSUPPORTED_FEATURE.DROP_DATABASE
  • _LEGACY_ERROR_TEMP_1150 => UNSUPPORTED_DATA_TYPE_FOR_DATASOURCE
  • _LEGACY_ERROR_TEMP_1220 => UNSUPPORTED_FEATURE.HIVE_TABLE_TYPE
  • _LEGACY_ERROR_TEMP_1265 => LOAD_DATA_PATH_NOT_EXISTS
  • _LEGACY_ERROR_TEMP_1277 => CREATE_VIEW_COLUMN_ARITY_MISMATCH.TOO_MANY_SOURCE_COLUMNS / CREATE_VIEW_COLUMN_ARITY_MISMATCH.NOT_ENOUGH_SOURCE_COLUMNS

Why are the changes needed?

The changes improve the error framework.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

  • Update & Add new UT.
  • Manually test.
  • Pass GA.

@github-actions github-actions bot added the AVRO label Jul 10, 2023
],
"sqlState" : "42710"
},
"CREATE_VIEW_COLUMN_ARITY_MISMATCH" : {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you align this new error class with the existing INSERT_COLUMN_ARITY_MISMATCH and output columns?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@MaxGekk
Copy link
Member

MaxGekk commented Jul 11, 2023

I believe the failure is not related to PR's changes:

RUN: /__w/spark/spark/dev/connect-gen-protos.sh /tmp/tmpo7t_pdiv
...
subprocess.CalledProcessError: Command '['/__w/spark/spark/dev/connect-gen-protos.sh', '/tmp/tmpo7t_pdiv']' returned non-zero exit status 1.
Error: Process completed with exit code 1.

+1, LGTM. Merging to master.
Thank you, @panbingkun.

@MaxGekk MaxGekk closed this in c5a23e9 Jul 11, 2023
@panbingkun
Copy link
Contributor Author

I believe the failure is not related to PR's changes:

RUN: /__w/spark/spark/dev/connect-gen-protos.sh /tmp/tmpo7t_pdiv
...
subprocess.CalledProcessError: Command '['/__w/spark/spark/dev/connect-gen-protos.sh', '/tmp/tmpo7t_pdiv']' returned non-zero exit status 1.
Error: Process completed with exit code 1.

+1, LGTM. Merging to master. Thank you, @panbingkun.

Yeah, it is not related to this PR, it is the problem of using the 'deprecated' method for the remote plugin of buf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants