Skip to content

[SPARK-44367][SQL][UI] Show error message on UI for each failed query#41951

Closed
yaooqinn wants to merge 5 commits intoapache:masterfrom
yaooqinn:SPARK-44367
Closed

[SPARK-44367][SQL][UI] Show error message on UI for each failed query#41951
yaooqinn wants to merge 5 commits intoapache:masterfrom
yaooqinn:SPARK-44367

Conversation

@yaooqinn
Copy link
Member

What changes were proposed in this pull request?

This PR adds an 'error message' col to the failed query execution table on the SQL/DataFrame tab of UI.

Why are the changes needed?

The SQL tab of UI is not helping to detect SQL errors. This PR will provide users with a clear understanding of why their queries have failed.

Does this PR introduce any user-facing change?

SQL tab of UI shows errors for failed queries

How was this patch tested?

built and tested locally

image

@yaooqinn
Copy link
Member Author

@cloud-fan
Copy link
Contributor

what's the old way to know the query error in the UI?

@yaooqinn
Copy link
Member Author

yaooqinn commented Jul 13, 2023

@cloud-fan

  • check the related failed job IDs for physical failures but not logical ones
  • (STS-specific) ThriftServer Page
  • Attach a custom UITab

@yaooqinn yaooqinn requested a review from cloud-fan July 13, 2023 10:55
@cloud-fan
Copy link
Contributor

If we click one query and enter the detail query page, will we see the error message before this PR?

@yaooqinn
Copy link
Member Author

If we click one query and enter the detail query page, will we see the error message before this PR?

NO

@yaooqinn
Copy link
Member Author

Hi @cloud-fan, Do you have any other concerns?

@cloud-fan
Copy link
Contributor

I'm not good at UI design but it seems a bit overkill to put the full error message in a column. Shall we only put the error class name (or java exception class name) in the column, and put the full error message in the query details page?

@yaooqinn
Copy link
Member Author

We can follow the task error on StagePage and the execution error on ThriftPage, display the first line which can be used to represent the error class, and toggle to show the collapsed details. WDYT?

@github-actions github-actions bot added the CORE label Jul 19, 2023
@yaooqinn
Copy link
Member Author

How about this?

image

image

@yaooqinn yaooqinn closed this in 3997055 Jul 20, 2023
yaooqinn added a commit that referenced this pull request Jul 20, 2023
### What changes were proposed in this pull request?

This PR adds an 'error message' col to the failed query execution table on the SQL/DataFrame tab of UI.

### Why are the changes needed?

The SQL tab of UI is not helping to detect SQL errors. This PR will provide users with a clear understanding of why their queries have failed.

### Does this PR introduce _any_ user-facing change?

SQL tab of UI shows errors for failed queries

### How was this patch tested?

built and tested locally

![image](https://github.com/apache/spark/assets/8326978/cf25e347-bb99-47f8-accd-aabaf8d3a9d8)

Closes #41951 from yaooqinn/SPARK-44367.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Kent Yao <yao@apache.org>
(cherry picked from commit 3997055)
Signed-off-by: Kent Yao <yao@apache.org>
@yaooqinn
Copy link
Member Author

Thanks, merged to master and 3.5.

PS, K8s IT failures are irrelevant.

@yaooqinn yaooqinn deleted the SPARK-44367 branch July 20, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants