[SPARK-43321][Connect][Followup] Better names for APIs used in Scala Client joinWith#41971
Closed
zhenlineo wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-43321][Connect][Followup] Better names for APIs used in Scala Client joinWith#41971zhenlineo wants to merge 2 commits intoapache:masterfrom
zhenlineo wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
cc @hvanhovell |
vicennial
approved these changes
Jul 12, 2023
| override def schema: StructType = StructType(StructField("value", dataType, nullable) :: Nil) | ||
| def lenientSerialization: Boolean = false | ||
| def isFlattenable: Boolean = false | ||
| def isStruct: Boolean = false // set to true if it is a struct encoder |
Contributor
There was a problem hiding this comment.
Nit: comment seems a bit redundant
| @@ -103,18 +102,18 @@ object AgnosticEncoders { | |||
| } | |||
|
|
|||
| // Contains a sequence of fields. The fields can be flattened to columns in a row. | |||
Contributor
There was a problem hiding this comment.
Nit: can also remove the word "flattened" in this comment here I think
Contributor
Author
|
cc @HyukjinKwon Can we merge this? Thanks. |
yaooqinn
approved these changes
Jul 13, 2023
Member
|
thanks, merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Directly use
structin the names to directly call out the underlying encoder is composed using a struct encoder.Why are the changes needed?
Addressing PR review feedbacks of #40997
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests