[SPARK-44361][SQL] Use PartitionEvaluator API in MapInBatchExec#42024
Closed
vinodkc wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-44361][SQL] Use PartitionEvaluator API in MapInBatchExec#42024vinodkc wants to merge 4 commits intoapache:masterfrom
vinodkc wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
cc @cloud-fan , @beliefer |
cloud-fan
reviewed
Jul 19, 2023
| * partition. | ||
| */ | ||
| @DeveloperApi | ||
| @Since("3.5.0") |
Contributor
There was a problem hiding this comment.
Ah, I missed to add this API to RDDBarrier
cloud-fan
approved these changes
Jul 19, 2023
Contributor
|
thanks, merging to master/3.5 (fix an issue that a new RDD API is missing in RDDBarrier)! |
cloud-fan
pushed a commit
that referenced
this pull request
Jul 19, 2023
### What changes were proposed in this pull request? SQL operator `MapInBatchExec` is updated to use the `PartitionEvaluator` API to do execution. Added a new method `mapPartitionsWithEvaluator` in `RDDBarrier`. ### Why are the changes needed? To avoid the use of lambda during distributed execution. Ref: SPARK-43061 for more details. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing test cases. Once all SQL operators are refactored, will enable `spark.sql.execution.usePartitionEvaluator` by default, so all tests cover this code path. Closes #42024 from vinodkc/br_SPARK-44361. Authored-by: Vinod KC <vinod.kc.in@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 9b43a9f) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
HyukjinKwon
added a commit
that referenced
this pull request
Jul 19, 2023
…statements ### What changes were proposed in this pull request? This PR is a followup of #42024 that removes unused variables and fix import statements (which should be the part of the whole refactoring). ### Why are the changes needed? To properly cleanup. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests should covoer Closes #42068 from HyukjinKwon/SPARK-44361-followup. Lead-authored-by: Hyukjin Kwon <gurwls223@apache.org> Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
added a commit
that referenced
this pull request
Jul 19, 2023
…statements ### What changes were proposed in this pull request? This PR is a followup of #42024 that removes unused variables and fix import statements (which should be the part of the whole refactoring). ### Why are the changes needed? To properly cleanup. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests should covoer Closes #42068 from HyukjinKwon/SPARK-44361-followup. Lead-authored-by: Hyukjin Kwon <gurwls223@apache.org> Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit bca28f8) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
cloud-fan
pushed a commit
that referenced
this pull request
Jul 28, 2023
…Exec ### What changes were proposed in this pull request? This is a follow-up of #42024, to set the partition index correctly even if it's not used for now. ### Why are the changes needed? future-proof ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? existing tests Closes #42189 from vinodkc/br_SPARK-44361_Followup. Authored-by: Vinod KC <vinod.kc.in@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
cloud-fan
pushed a commit
that referenced
this pull request
Jul 28, 2023
…Exec ### What changes were proposed in this pull request? This is a follow-up of #42024, to set the partition index correctly even if it's not used for now. ### Why are the changes needed? future-proof ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? existing tests Closes #42189 from vinodkc/br_SPARK-44361_Followup. Authored-by: Vinod KC <vinod.kc.in@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 3cf88cb) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SQL operator
MapInBatchExecis updated to use thePartitionEvaluatorAPI to do execution.Added a new method
mapPartitionsWithEvaluatorinRDDBarrier.Why are the changes needed?
To avoid the use of lambda during distributed execution.
Ref: SPARK-43061 for more details.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing test cases. Once all SQL operators are refactored, will enable
spark.sql.execution.usePartitionEvaluatorby default, so all tests cover this code path.