[SPARK-43035][Connect] Add error class in Spark Connect server's ErrorInfo#42053
Closed
shrutiverma29 wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-43035][Connect] Add error class in Spark Connect server's ErrorInfo#42053shrutiverma29 wants to merge 3 commits intoapache:masterfrom
shrutiverma29 wants to merge 3 commits intoapache:masterfrom
Conversation
MaxGekk
reviewed
Oct 16, 2023
| case e: Exception => | ||
| logError("Error starting Spark Connect server", e) | ||
| e.getCause match { | ||
| case sparkThrowable: SparkThrowable if (sparkThrowable.getErrorClass != null) => |
Member
There was a problem hiding this comment.
Can you add a test for the case?
shrutiverma29
force-pushed
the
feat/errorHandling
branch
from
0ed1045 to
03d717e
Compare
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds error handling in case error is of type SparkThrowable
Why are the changes needed?
The changes are needed so that user can have a bit more idea about the error
Does this PR introduce any user-facing change?
User will be able to see specific error in case of SparkThrowable Exceptions
How was this patch tested?