[MINOR][UI] Simplify columnDefs in stagepage.js#42101
Closed
yaooqinn wants to merge 1 commit intoapache:masterfrom
Closed
[MINOR][UI] Simplify columnDefs in stagepage.js#42101yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
cc @ulysses-you |
ulysses-you
reviewed
Jul 21, 2023
Contributor
|
I tested it locally with accumulator, looks fine to me |
Member
Author
|
thanks @ulysses-you for the verification |
Member
|
cc @gengliangwang and @sarutak FYI |
sarutak
approved these changes
Jul 22, 2023
Member
sarutak
left a comment
sarutak
left a comment
There was a problem hiding this comment.
Yeah, we can refactor like this change.
https://datatables.net/reference/option/columnDefs
Member
|
GA failure seems not to be relevant to this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Simplify
columnDefsin stagepage.jsWhy are the changes needed?
Reduce hardcode in stagepage.js and potential inconsistency for hidden/show in future changes.
Does this PR introduce any user-facing change?
no
How was this patch tested?
Locally verified.