[SPARK-44608][SQL] Remove unused definitions from DataTypeExpression#42240
Closed
LuciferYang wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-44608][SQL] Remove unused definitions from DataTypeExpression#42240LuciferYang wants to merge 1 commit intoapache:masterfrom
DataTypeExpression#42240LuciferYang wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@amaliujia Can we temporarily delete this useless definitions? |
Contributor
|
@LuciferYang we added this for the completeness of DataTypeExpressions. It is just natural that each data type has its DataTypeExpression. Does it cause any problem so far? |
Contributor
Author
|
@amaliujia These are some unused and untested code, and they are public. If they are released in Spark 3.5, we have an obligation to continue maintaining them and ensuring compatibility, even if they will never be used, which itself is a risk. So I prefer to define when there are actual needs Of course, if we are confident that they will be used and tested soon, then I think there is no problem keeping these definitions |
Contributor
Author
|
@amaliujia Let’s keep these definitions, I respect your choice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#41559 have defined some
DataTypeExpressionbut did not use, such asByteTypeExpression,ShortTypeExpression, etc. This pr cleans them up and we can define them when we really need.Why are the changes needed?
Code cleanup
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions