Skip to content

[MINOR][UI] Increasing the number of significant digits for Fraction Cached of RDD #42373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 2 commits into from
Closed

[MINOR][UI] Increasing the number of significant digits for Fraction Cached of RDD #42373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d4387c
[MINOR][UI] Increasing the number of significant digits for Fraction …
yaooqinn Aug 7, 2023
25c77cf
tests
yaooqinn Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/ui/storage/StoragePage.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ private[ui] class StoragePage(parent: SparkUITab, store: AppStatusStore) extends
<td>{rdd.storageLevel}
</td>
<td>{rdd.numCachedPartitions.toString}</td>
<td>{"%.0f%%".format(rdd.numCachedPartitions * 100.0 / rdd.numPartitions)}</td>
<td>{"%.2f%%".format(rdd.numCachedPartitions * 100.0 / rdd.numPartitions)}</td>
<td sorttable_customkey={rdd.memoryUsed.toString}>{Utils.bytesToString(rdd.memoryUsed)}</td>
<td sorttable_customkey={rdd.diskUsed.toString} >{Utils.bytesToString(rdd.diskUsed)}</td>
</tr>
Expand Down
15 changes: 8 additions & 7 deletions core/src/test/scala/org/apache/spark/ui/storage/StoragePageSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ class StoragePageSuite extends SparkFunSuite {

val rdd2 = new RDDStorageInfo(2,
"rdd2",
10,
5,
1000,
56,
StorageLevel.DISK_ONLY.description,
0L,
200L,
Expand All @@ -58,8 +58,8 @@ class StoragePageSuite extends SparkFunSuite {

val rdd3 = new RDDStorageInfo(3,
"rdd3",
10,
10,
1000,
103,
StorageLevel.MEMORY_AND_DISK_SER.description,
400L,
500L,
Expand Down Expand Up @@ -94,19 +94,20 @@ class StoragePageSuite extends SparkFunSuite {

assert((xmlNodes \\ "tr").size === 3)
assert(((xmlNodes \\ "tr")(0) \\ "td").map(_.text.trim) ===
Seq("1", "rdd1", "Memory Deserialized 1x Replicated", "10", "100%", "100.0 B", "0.0 B"))
Seq("1", "rdd1", "Memory Deserialized 1x Replicated", "10", "100.00%", "100.0 B", "0.0 B"))
// Check the url
assert(((xmlNodes \\ "tr")(0) \\ "td" \ "a")(0).attribute("href").map(_.text) ===
Some("http://localhost:4040/storage/rdd/?id=1"))

assert(((xmlNodes \\ "tr")(1) \\ "td").map(_.text.trim) ===
Seq("2", "rdd2", "Disk Serialized 1x Replicated", "5", "50%", "0.0 B", "200.0 B"))
Seq("2", "rdd2", "Disk Serialized 1x Replicated", "56", "5.60%", "0.0 B", "200.0 B"))
// Check the url
assert(((xmlNodes \\ "tr")(1) \\ "td" \ "a")(0).attribute("href").map(_.text) ===
Some("http://localhost:4040/storage/rdd/?id=2"))

assert(((xmlNodes \\ "tr")(2) \\ "td").map(_.text.trim) ===
Seq("3", "rdd3", "Disk Memory Serialized 1x Replicated", "10", "100%", "400.0 B", "500.0 B"))
Seq("3", "rdd3", "Disk Memory Serialized 1x Replicated", "103", "10.30%", "400.0 B",
"500.0 B"))
// Check the url
assert(((xmlNodes \\ "tr")(2) \\ "td" \ "a")(0).attribute("href").map(_.text) ===
Some("http://localhost:4040/storage/rdd/?id=3"))
Expand Down