[SPARK-44722][CONNECT] ExecutePlanResponseReattachableIterator._call_iter: AttributeError: 'NoneType' object has no attribute 'message'#42397
Closed
juliuszsompolski wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
HyukjinKwon
approved these changes
Aug 8, 2023
Member
|
Merged to master and branch-3.5. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Aug 8, 2023
…iter: AttributeError: 'NoneType' object has no attribute 'message' ### What changes were proposed in this pull request? Tiny error during exception handling: status might in some cases be None. Make a similar change in scala client just to be defensive, because there it appears that it may never happen (when we catch `StatusRuntimeException`, `StatusProto.fromThrowable` should never return null). ### Why are the changes needed? Fix an error during reattach retry handling. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tests that will be published in a followup. Closes #42397 from juliuszsompolski/SPARK-44722. Authored-by: Juliusz Sompolski <julek@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit ea00ecd) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
…iter: AttributeError: 'NoneType' object has no attribute 'message' ### What changes were proposed in this pull request? Tiny error during exception handling: status might in some cases be None. Make a similar change in scala client just to be defensive, because there it appears that it may never happen (when we catch `StatusRuntimeException`, `StatusProto.fromThrowable` should never return null). ### Why are the changes needed? Fix an error during reattach retry handling. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tests that will be published in a followup. Closes apache#42397 from juliuszsompolski/SPARK-44722. Authored-by: Juliusz Sompolski <julek@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Tiny error during exception handling: status might in some cases be None.
Make a similar change in scala client just to be defensive, because there it appears that it may never happen (when we catch
StatusRuntimeException,StatusProto.fromThrowableshould never return null).Why are the changes needed?
Fix an error during reattach retry handling.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tests that will be published in a followup.