Skip to content

[SPARK-43660][CONNECT][PS][FOLLOWUP] Remove JVM dependency for resample#42410

Closed
itholic wants to merge 4 commits intoapache:masterfrom
itholic:resample_followup
Closed

[SPARK-43660][CONNECT][PS][FOLLOWUP] Remove JVM dependency for resample#42410
itholic wants to merge 4 commits intoapache:masterfrom
itholic:resample_followup

Conversation

@itholic
Copy link
Contributor

@itholic itholic commented Aug 9, 2023

What changes were proposed in this pull request?

This is follow-up for #41877 to remove JVM dependency.

Why are the changes needed?

To remove JVM dependency from Pandas API on Spark with Spark Connect.

Does this PR introduce any user-facing change?

No, it's internal handling.

How was this patch tested?

The existing UT.

@itholic
Copy link
Contributor Author

itholic commented Aug 9, 2023

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Aug 9, 2023

Merged to master and branch-3.5.

HyukjinKwon pushed a commit that referenced this pull request Aug 9, 2023
### What changes were proposed in this pull request?

This is follow-up for #41877 to remove JVM dependency.

### Why are the changes needed?

To remove JVM dependency from Pandas API on Spark with Spark Connect.

### Does this PR introduce _any_ user-facing change?

No, it's internal handling.

### How was this patch tested?

The existing UT.

Closes #42410 from itholic/resample_followup.

Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit b19a83e)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@HyukjinKwon
Copy link
Member

Oops, I didn't see the tests are still running. Reverting

@HyukjinKwon HyukjinKwon reopened this Aug 9, 2023
@HyukjinKwon
Copy link
Member

@itholic please fix the linter

@itholic
Copy link
Contributor Author

itholic commented Aug 10, 2023

CI passed. @HyukjinKwon FYI

@zhengruifeng
Copy link
Contributor

LGTM, merged to master

hvanhovell pushed a commit to hvanhovell/spark that referenced this pull request Aug 13, 2023
### What changes were proposed in this pull request?

This is follow-up for apache#41877 to remove JVM dependency.

### Why are the changes needed?

To remove JVM dependency from Pandas API on Spark with Spark Connect.

### Does this PR introduce _any_ user-facing change?

No, it's internal handling.

### How was this patch tested?

The existing UT.

Closes apache#42410 from itholic/resample_followup.

Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
hvanhovell pushed a commit to hvanhovell/spark that referenced this pull request Aug 13, 2023
### What changes were proposed in this pull request?

This is follow-up for apache#41877 to remove JVM dependency.

### Why are the changes needed?

To remove JVM dependency from Pandas API on Spark with Spark Connect.

### Does this PR introduce _any_ user-facing change?

No, it's internal handling.

### How was this patch tested?

The existing UT.

Closes apache#42410 from itholic/resample_followup.

Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
valentinp17 pushed a commit to valentinp17/spark that referenced this pull request Aug 24, 2023
### What changes were proposed in this pull request?

This is follow-up for apache#41877 to remove JVM dependency.

### Why are the changes needed?

To remove JVM dependency from Pandas API on Spark with Spark Connect.

### Does this PR introduce _any_ user-facing change?

No, it's internal handling.

### How was this patch tested?

The existing UT.

Closes apache#42410 from itholic/resample_followup.

Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
valentinp17 pushed a commit to valentinp17/spark that referenced this pull request Aug 24, 2023
### What changes were proposed in this pull request?

This is follow-up for apache#41877 to remove JVM dependency.

### Why are the changes needed?

To remove JVM dependency from Pandas API on Spark with Spark Connect.

### Does this PR introduce _any_ user-facing change?

No, it's internal handling.

### How was this patch tested?

The existing UT.

Closes apache#42410 from itholic/resample_followup.

Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
@itholic itholic deleted the resample_followup branch November 20, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants