[SPARK-44554][INFRA][FOLLOWUP] Install IPython for the Python linter check in the daily test for branch-3.3#42413
Closed
LuciferYang wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
LuciferYang
changed the title
IPython for branch-3.3 Python linter check.IPython for the Python linter check in the daily test for branch-3.3.
LuciferYang
changed the title
IPython for the Python linter check in the daily test for branch-3.3.IPython for the Python linter check in the daily test for branch-3.3
Contributor
Author
|
cc @zhengruifeng FYI |
LuciferYang
commented
Aug 9, 2023
| # Should delete this section after SPARK 3.3 EOL. | ||
| python3.9 -m pip install 'flake8==3.9.0' pydata_sphinx_theme 'mypy==0.920' 'pytest==7.1.3' 'pytest-mypy-plugins==1.9.3' numpydoc 'jinja2<3.0.0' 'black==21.12b0' | ||
| python3.9 -m pip install 'pandas-stubs==1.2.0.53' | ||
| python3.9 -m pip install 'pandas-stubs==1.2.0.53' ipython |
Contributor
Author
There was a problem hiding this comment.
I found https://github.com/apache/spark/pull/39716/files move ipython install from Install dependencies for documentation generation to Install Python linter dependencies
zhengruifeng
approved these changes
Aug 9, 2023
HyukjinKwon
approved these changes
Aug 9, 2023
Contributor
Author
|
Merged into master. Thanks @HyukjinKwon @zhengruifeng |
Contributor
Author
|
https://github.com/apache/spark/actions/runs/5817966464 
The last test was successful |
Contributor
|
@LuciferYang awesome, finally! but it really too cumbersome to maintain, we need to figure out how to simplify it. |
hvanhovell
pushed a commit
to hvanhovell/spark
that referenced
this pull request
Aug 13, 2023
…r check in the daily test for branch-3.3 ### What changes were proposed in this pull request? This pr aims to install `IPython` for the Python linter check in the daily test for branch-3.3. ### Why are the changes needed? To fix the Python linter check in the daily test of branch-3.3. https://github.com/apache/spark/actions/runs/5805901293/job/15737802378 <img width="1030" alt="image" src="https://github.com/apache/spark/assets/1475305/59896b6a-b710-4772-9139-189c7ea73fe5"> ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Monitor GA Closes apache#42413 from LuciferYang/SPARK-44554-FOLLOWUP. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: yangjie01 <yangjie01@baidu.com>
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
…r check in the daily test for branch-3.3 ### What changes were proposed in this pull request? This pr aims to install `IPython` for the Python linter check in the daily test for branch-3.3. ### Why are the changes needed? To fix the Python linter check in the daily test of branch-3.3. https://github.com/apache/spark/actions/runs/5805901293/job/15737802378 <img width="1030" alt="image" src="https://github.com/apache/spark/assets/1475305/59896b6a-b710-4772-9139-189c7ea73fe5"> ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Monitor GA Closes apache#42413 from LuciferYang/SPARK-44554-FOLLOWUP. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: yangjie01 <yangjie01@baidu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to install
IPythonfor the Python linter check in the daily test for branch-3.3.Why are the changes needed?
To fix the Python linter check in the daily test of branch-3.3.
https://github.com/apache/spark/actions/runs/5805901293/job/15737802378
Does this PR introduce any user-facing change?
No
How was this patch tested?
Monitor GA