[HOTFIX] Rename the identifier of driver from <driver> to driver#4245
Closed
sarutak wants to merge 1 commit into
Closed
[HOTFIX] Rename the identifier of driver from <driver> to driver#4245sarutak wants to merge 1 commit into
<driver> to driver#4245sarutak wants to merge 1 commit into
Conversation
…he identifier is used for metrics name
Contributor
|
This could provide a usability regression for people since the name now appears differently in the UI. Is there any way we can intercept this somewhere downstream and not change it here? |
Member
Author
|
How about escaping specific characters like |
Member
Author
|
I found this issue is resolved by updating |
|
Test build #26221 has finished for PR 4245 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is related to #3812.
The identifier of driver is defined as
<driver>but this identifier is used for metrics name and some metrics sinks cannot parse<and>.