Skip to content

Comments

[SPARK-44786][SQL][CONNECT] Convert common Spark exceptions#42472

Closed
heyihong wants to merge 1 commit intoapache:masterfrom
heyihong:SPARK-44786
Closed

[SPARK-44786][SQL][CONNECT] Convert common Spark exceptions#42472
heyihong wants to merge 1 commit intoapache:masterfrom
heyihong:SPARK-44786

Conversation

@heyihong
Copy link
Contributor

@heyihong heyihong commented Aug 12, 2023

What changes were proposed in this pull request?

  • Convert common Spark exceptions
  • Extend common Spark exceptions to support single message parameter constructor

Why are the changes needed?

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • Existing tests

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the conflicts should be resolved.

@heyihong heyihong force-pushed the SPARK-44786 branch 3 times, most recently from af4321f to 447469e Compare August 21, 2023 23:19
@HyukjinKwon
Copy link
Member

Merged to master and branch-3.5.

HyukjinKwon pushed a commit that referenced this pull request Aug 22, 2023
- Convert common Spark exceptions
- Extend common Spark exceptions to support single message parameter constructor

- Achieve similar exception conversion coverage as [Python Client](https://github.com/apache/spark/blob/master/python/pyspark/errors/exceptions/connect.py#L57-L89)

No

- Existing tests

Closes #42472 from heyihong/SPARK-44786.

Authored-by: Yihong He <yihong.he@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit dc900b4)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
valentinp17 pushed a commit to valentinp17/spark that referenced this pull request Aug 24, 2023
### What changes were proposed in this pull request?

- Convert common Spark exceptions
- Extend common Spark exceptions to support single message parameter constructor

### Why are the changes needed?

- Achieve similar exception conversion coverage as [Python Client](https://github.com/apache/spark/blob/master/python/pyspark/errors/exceptions/connect.py#L57-L89)

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

- Existing tests

Closes apache#42472 from heyihong/SPARK-44786.

Authored-by: Yihong He <yihong.he@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants