[SPARK-44809][SS] Remove unused RocksDB custom metrics for pause/writeBatch#42491
Closed
anishshri-db wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-44809][SS] Remove unused RocksDB custom metrics for pause/writeBatch#42491anishshri-db wants to merge 1 commit intoapache:masterfrom
anishshri-db wants to merge 1 commit intoapache:masterfrom
Conversation
anishshri-db
changed the title
anishshri-db
changed the title
Contributor
Author
|
cc - @HeartSaVioR - PTAL, thx ! |
Contributor
Author
|
I don't think error is related to the change. Seems like a transient/timing issue with awaitOffset. Locally, tests run fine. Ran suite multiple times |
Contributor
|
@anishshri-db Can we retry the build for completeness' sake? |
Contributor
Author
|
All tests passing fine now - https://github.com/anishshri-db/spark/actions/runs/5861353460/job/15927525392 |
Contributor
|
https://github.com/anishshri-db/spark/actions/runs/5861353460/attempts/2 <= This passed. Thanks! Merging to master. |
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
…eBatch ### What changes were proposed in this pull request? Remove unused RocksDB custom metrics for pause/writeBatch ### Why are the changes needed? Remove unused metrics from query progress ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Modified existing tests ``` [info] Run completed in 23 seconds, 724 milliseconds. [info] Total number of tests run: 11 [info] Suites: completed 1, aborted 0 [info] Tests: succeeded 11, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. [success] Total time: 53 s, completed Aug 14, 2023, 3:30:56 PM ``` Closes apache#42491 from anishshri-db/task/SPARK-44809. Authored-by: Anish Shrigondekar <anish.shrigondekar@databricks.com> Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove unused RocksDB custom metrics for pause/writeBatch
Why are the changes needed?
Remove unused metrics from query progress
Does this PR introduce any user-facing change?
No
How was this patch tested?
Modified existing tests